Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move .yahoo_quoted class checking to new function #4112

Closed
namangupta01 opened this issue Dec 3, 2018 · 11 comments · Fixed by #8640
Closed

Move .yahoo_quoted class checking to new function #4112

namangupta01 opened this issue Dec 3, 2018 · 11 comments · Fixed by #8640
Assignees
@namangupta01
Labels
good first issue help wanted requires help by anyone willing to contribute Ruby

Comments

@namangupta01
Copy link
Member

Here, we are checking for the presence of .yahoo_quoted

plots2/app/models/comment.rb

Line 300 in ff870de

if mail_doc.css(".yahoo_quoted")

We can improve this by moving this checking into the new function just like we have for gmail.

plots2/app/models/comment.rb

Line 291 in ff870de

def self.gmail_quote_present?(mail_doc)

@namangupta01 namangupta01 changed the title Move .yahoo_quote class checking to new class Move .yahoo_quoted class checking to new class Dec 3, 2018
@digitaldina
Copy link
Collaborator

I will take this!
Please add to GCI dashboard!

@namangupta01 namangupta01 changed the title Move .yahoo_quoted class checking to new class Move .yahoo_quoted class checking to new function Dec 4, 2018
@SidharthBansal
Copy link
Member

Published on the GCI dashboard.
Please claim it before anyone else claims it.
Thanks

@SidharthBansal SidharthBansal added the has-pull-request issues which already have a pull request solving it label Dec 6, 2018
@namangupta01
Copy link
Member Author

@SidharthBansal where is the pull request for this?

@SidharthBansal
Copy link
Member

Sorry. Put label in wrong issue.

@SidharthBansal SidharthBansal removed the has-pull-request issues which already have a pull request solving it label Dec 6, 2018
@SidharthBansal
Copy link
Member

No one is currently working on this issue

@digitaldina
Copy link
Collaborator

digitaldina commented Dec 6, 2018 •
edited

changed my mind... see below comment :)

@digitaldina
Copy link
Collaborator

@SidharthBansal I will take this once I get this GCI task approved: https://codein.withgoogle.com/dashboard/task-instances/4824240835526656/

@digitaldina
Copy link
Collaborator

@namangupta01 what do you mean by moving it to a new function? I see that it is inside a function just like the gmail one here :

plots2/app/models/comment.rb

Line 299 in ff870de

def self.yahoo_parsed_mail(mail_doc)

@grvsachdeva
Copy link
Member

Hi @dinaelhanan, what @namangupta01 meant is creating a new function named yahoo_quote_present? which would be similar in working to Gmail's function mentioned here- #4112 (comment)

The goal is to replace the line

plots2/app/models/comment.rb

Line 300 in ff870de

if mail_doc.css(".yahoo_quoted")
with the function.

Let us know if you want further details. Thanks!

@grvsachdeva grvsachdeva added help wanted requires help by anyone willing to contribute Ruby good first issue labels Jan 22, 2019
@kimcheung
Copy link
Contributor

Looks like this is still open, can I take it?

@kimcheung kimcheung mentioned this issue Oct 20, 2020
Merged
5 tasks
@kimcheung
Copy link
Contributor

PR posted #8640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namangupta01 namangupta01

Labels
good first issue help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create function to test yahoo quote present kimcheung/plots2
5 participants
@kimcheung @digitaldina @namangupta01 @grvsachdeva @SidharthBansal