Create function to test yahoo quote present #8640

kimcheung · 2020-10-20T16:45:50Z

Fixes #4112 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

gitpod-io · 2020-10-20T16:45:55Z

app/models/comment.rb

codecov · 2020-10-20T16:49:10Z

Codecov Report

Merging #8640 into main will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8640      +/-   ##
==========================================
+ Coverage   81.76%   81.89%   +0.12%     
==========================================
  Files         101      101              
  Lines        5901     5903       +2     
==========================================
+ Hits         4825     4834       +9     
+ Misses       1076     1069       -7

Impacted Files	Coverage Δ
app/controllers/user_tags_controller.rb	`84.28% <100.00%> (ø)`
app/models/comment.rb	`77.66% <100.00%> (+0.14%)`	⬆️
app/api/srch/search.rb	`70.70% <0.00%> (+3.82%)`	⬆️
app/services/execute_search.rb	`94.44% <0.00%> (+5.55%)`	⬆️

app/models/comment.rb

kimcheung · 2020-10-20T17:48:38Z

@publiclab/reviewers looks like the Travis CI here failed during build setup of downloading dependencies. How do I retrigger the run?

tawahpeggy · 2020-10-20T20:17:17Z

@kimcheung did everything go well on your machine or did you only notice errors during the PR?

kimcheung · 2020-10-20T20:33:27Z

@tawahpeggy I didn't run any tests locally... just when I created the PR. How do I run the tests locally?

tawahpeggy · 2020-10-20T20:39:42Z

am not really sure but try this it might work Run : rails test to confirm that your install is working properly. Or rails test:system for system tests

kimcheung · 2020-10-20T21:03:59Z

@tawahpeggy But I think since this is more a dependency downloading issue, I think retriggering the Travis CI should resolve the issue?

Just saw Jeff's response. closing this PR and re-opening should retrigger it. Thanks!

gitpod-io · 2020-10-20T21:08:37Z

tawahpeggy · 2020-10-20T21:35:00Z

you are welcome please let me know when it woks, am eager to find out

kimcheung · 2020-10-20T23:01:55Z

@tawahpeggy that did it; now it's properly failing on the tests

codeclimate · 2020-10-21T02:55:42Z

Code Climate has analyzed commit 9f18870 and detected 0 issues on this pull request.

View more on Code Climate.

kimcheung · 2020-10-21T03:17:51Z

@publiclab/reviewers please review :)

cesswairimu

🎉

cesswairimu · 2020-10-21T13:27:44Z

Thanks @kimcheung for working on this 🎉

* Create function for yahoo quote present * Set return values in function * Fix return * refactor * Add missing end * Fix typo

Create function for yahoo quote present

5b30ee8

codeclimate bot reviewed Oct 20, 2020

View reviewed changes

app/models/comment.rb Outdated Show resolved Hide resolved

Set return values in function

c4d71f0

codeclimate bot reviewed Oct 20, 2020

View reviewed changes

app/models/comment.rb Outdated Show resolved Hide resolved

Fix return

e6d6982

codeclimate bot reviewed Oct 20, 2020

View reviewed changes

app/models/comment.rb Show resolved Hide resolved

kimcheung added 2 commits October 20, 2020 13:17

refactor

f38e189

Add missing end

3425c3f

kimcheung changed the title ~~Create function for yahoo quote present~~ Create function to test yahoo quote present Oct 20, 2020

kimcheung closed this Oct 20, 2020

kimcheung reopened this Oct 20, 2020

Fix typo

9f18870

kimcheung marked this pull request as ready for review October 21, 2020 03:17

kimcheung requested a review from a team as a code owner October 21, 2020 03:17

kimcheung mentioned this pull request Oct 21, 2020

Move .yahoo_quoted class checking to new function #4112

Closed

cesswairimu requested a review from namangupta01 October 21, 2020 12:56

cesswairimu approved these changes Oct 21, 2020

View reviewed changes

cesswairimu merged commit 828321c into publiclab:main Oct 21, 2020

piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020

Create function to test yahoo quote present (publiclab#8640)

471825b

* Create function for yahoo quote present * Set return values in function * Fix return * refactor * Add missing end * Fix typo

manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021

Create function to test yahoo quote present (publiclab#8640)

0e0e14f

* Create function for yahoo quote present * Set return values in function * Fix return * refactor * Add missing end * Fix typo

lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021

Create function to test yahoo quote present (publiclab#8640)

2d2b10e

* Create function for yahoo quote present * Set return values in function * Fix return * refactor * Add missing end * Fix typo

ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021

Create function to test yahoo quote present (publiclab#8640)

ac3a3a8

* Create function for yahoo quote present * Set return values in function * Fix return * refactor * Add missing end * Fix typo

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create function to test yahoo quote present #8640

Create function to test yahoo quote present #8640

kimcheung commented Oct 20, 2020 •

edited

gitpod-io bot commented Oct 20, 2020 •

edited

codecov bot commented Oct 20, 2020 •

edited

kimcheung commented Oct 20, 2020

tawahpeggy commented Oct 20, 2020

kimcheung commented Oct 20, 2020 •

edited

tawahpeggy commented Oct 20, 2020

kimcheung commented Oct 20, 2020 •

edited

gitpod-io bot commented Oct 20, 2020

tawahpeggy commented Oct 20, 2020

kimcheung commented Oct 20, 2020

codeclimate bot commented Oct 21, 2020

kimcheung commented Oct 21, 2020

cesswairimu left a comment

cesswairimu commented Oct 21, 2020

Create function to test yahoo quote present #8640

Create function to test yahoo quote present #8640

Conversation

kimcheung commented Oct 20, 2020 • edited

gitpod-io bot commented Oct 20, 2020 • edited

codecov bot commented Oct 20, 2020 • edited

Codecov Report

kimcheung commented Oct 20, 2020

tawahpeggy commented Oct 20, 2020

kimcheung commented Oct 20, 2020 • edited

tawahpeggy commented Oct 20, 2020

kimcheung commented Oct 20, 2020 • edited

gitpod-io bot commented Oct 20, 2020

tawahpeggy commented Oct 20, 2020

kimcheung commented Oct 20, 2020

codeclimate bot commented Oct 21, 2020

kimcheung commented Oct 21, 2020

cesswairimu left a comment

Choose a reason for hiding this comment

cesswairimu commented Oct 21, 2020

kimcheung commented Oct 20, 2020 •

edited

gitpod-io bot commented Oct 20, 2020 •

edited

codecov bot commented Oct 20, 2020 •

edited

kimcheung commented Oct 20, 2020 •

edited

kimcheung commented Oct 20, 2020 •

edited