-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching error at /search bar #4270
Comments
@publiclab/reviewers This could be a |
Super! This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself! |
This is looking good! However i think for it to be a full first-timers-only issue we'd have to suggest a concrete specific code change -- what it should be changed to. Could you offer the final solution in code for it to be changed to?
Remember a FTO is often more to help people learn the collaboration process than to solve the specific code problem. Thanks! |
And great work! |
@jywarren Made the DIFF ... All good now.. Please add the |
Hey I'd like to claim this issue please! |
Yes, you can work on this one! |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the file
plots2/app/views/search/new.html.erb
Lines 8 to 13 in 7e8ba8e
plots2
repository (press the little pen Icon) and edit the line as shown below.Problem
When you don't write anything in the search bar and still press the search button.. it searches for
/search/
therefore comes back to/search
once again..Solution
I think we could change the search box code and mark that field as
required
See this page for some help in taking your first steps!
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
The text was updated successfully, but these errors were encountered: