Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
add logo of Public Lab along with heading #4424
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
On Fri, Dec 28, 2018, 8:06 PM Rishabh ***@***.*** wrote: @SidharthBansal <https://github.com/SidharthBansal> can i make seperate ftos for fa icons ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4424 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ_fSyIVqymPbpCPt8Ld8VEVIrxYqks5u9ixhgaJpZM4Zirry> .
Hi @rohan2599 - apologies for not continuing the community design discussion here a bit. I really appreciate your PR! We do need to think through a few things first, however.
Your code and screenshot look really nice. The big questions are,
#4690 has the most documentation about header wrapping.
In general, my other concern design-wise is just that the logo may not render well at such a small size. This is not a criticism of the idea of putting it in the header, really, more a shortcoming of the logo design itself (which i helped design, so i can be extra critical
What if we thought about placing the logo in the footer, like this perhaps? This would avoid the complication of the folding header issue:
This would have to be implemented in a db feature, however, and wouldn't need a PR.
Apologies for the slow decisionmaking on this; the header is a difficult to design and maintain section that has broken a lot recently, so we're just taking extra care in making changes. Thanks for your patience and for your help!!!!
If folks have other ideas, let's exchange screenshots a bit!