New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logo of Public Lab along with heading #4424

Open
geekychaser opened this Issue Dec 27, 2018 · 22 comments

Comments

Projects
None yet
8 participants
@geekychaser
Copy link
Contributor

geekychaser commented Dec 27, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 add logo of Public Lab along with heading

code link - https://github.com/publiclab/plots2/blob/master/app/views/layouts/_header.html.erb#L14

image

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@geekychaser

This comment has been minimized.

Copy link
Contributor Author

geekychaser commented Dec 27, 2018

@SidharthBansal please add fto label

@oorjitchowdhary

This comment has been minimized.

Copy link
Collaborator

oorjitchowdhary commented Dec 27, 2018

@geekychaser please mention the code links and also the solution...
FTO issues are meant to introduce new people to our codebase

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Dec 27, 2018

yes, @geekychaser please add relevant code links, issue description and then get it labeled. Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Dec 28, 2018

Let's ask @jywarren @publiclab/community-reps before starting with this issue. Thanks!

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Dec 28, 2018

Let's also add fa icons for store and donate.

@geekychaser

This comment has been minimized.

Copy link
Contributor Author

geekychaser commented Dec 28, 2018

@gauravano yes, i have added the code link also lets wait for the confirmation

@geekychaser

This comment has been minimized.

Copy link
Contributor Author

geekychaser commented Dec 28, 2018

@SidharthBansal can i make seperate ftos for fa icons ?

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Dec 29, 2018

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 21, 2019

Logo is available at https://publiclab.org/wiki/logo. @publiclab/community-reps what do you think about this issue?

If you agree, please also see if the logo in wiki seems good. I think if we are adding logo then may be logo without having publiclab.org would look more good.

Thanks!

@geekychaser

This comment has been minimized.

Copy link
Contributor Author

geekychaser commented Jan 21, 2019

@gauravano Yes, I totally agree with you

@BodeSpezial

This comment has been minimized.

Copy link

BodeSpezial commented Jan 24, 2019

I'll want to try it @geekychaser

@geekychaser

This comment has been minimized.

Copy link
Contributor Author

geekychaser commented Jan 24, 2019

@BodeSpezial Yeah, you can do it but let us wait for confirmation from @publiclab/community-reps

@steviepubliclab

This comment has been minimized.

Copy link
Contributor

steviepubliclab commented Jan 28, 2019

Hi all,
Just seeing this. Can you clarify where you're hoping to put the logos? (maybe a screenshot with arrows?

Thanks!
-Stevie

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 28, 2019

Hey @steviepubliclab, just adjacent to Public Lab heading

nav_logo

Thanks!

@rohanpalhappy

This comment has been minimized.

Copy link

rohanpalhappy commented Feb 12, 2019

I am taking up this issue. I see that there is no PR already. So most probably, I can try my hands on the code.

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Feb 12, 2019

Hi @rohanpalhappy, this issue is currently in the discussion stage and we are waiting for @publiclab/community-reps approval for the design. Thanks!

@rohanpalhappy rohanpalhappy referenced a pull request that will close this issue Feb 12, 2019

Open

Added Logo of Public Lab on header #4794

5 of 5 tasks complete
@rohanpalhappy

This comment has been minimized.

Copy link

rohanpalhappy commented Feb 12, 2019

I've PRed #4794 #4794 Please check it out

@rohanpalhappy

This comment has been minimized.

Copy link

rohanpalhappy commented Feb 12, 2019

okay @gauravano

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Feb 13, 2019

Hi @rohan2599 - apologies for not continuing the community design discussion here a bit. I really appreciate your PR! We do need to think through a few things first, however.

Your code and screenshot look really nice. The big questions are,

  1. how does it read at different screen widths? We have a set of issues with the navbar folding onto 2 lines, see #4163 #4189 #4189

@jywarren jywarren closed this Feb 13, 2019

@jywarren jywarren reopened this Feb 13, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Feb 13, 2019

Ack, sorry! I clicked the button when i didn't mean to! Let me continue writing...

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Feb 13, 2019

#4690 has the most documentation about header wrapping.

In general, my other concern design-wise is just that the logo may not render well at such a small size. This is not a criticism of the idea of putting it in the header, really, more a shortcoming of the logo design itself (which i helped design, so i can be extra critical 😄 ).

What if we thought about placing the logo in the footer, like this perhaps? This would avoid the complication of the folding header issue:

screen shot 2019-02-13 at 11 59 49 am

This would have to be implemented in a db feature, however, and wouldn't need a PR.

Apologies for the slow decisionmaking on this; the header is a difficult to design and maintain section that has broken a lot recently, so we're just taking extra care in making changes. Thanks for your patience and for your help!!!!

If folks have other ideas, let's exchange screenshots a bit!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Feb 14, 2019

Ah, to be honest, the above design is not looking that good. It's disturbing the alignment of paragraphs in footer. Let's keep thinking about other places. Also, if the header issue is solved, we can try the logo there too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment