Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time and link to email digest header #5340

Open
first-timers bot opened this issue Apr 2, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@first-timers
Copy link

commented Apr 2, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/subscription_mailer/send_digest.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -1,10 +1,11 @@
 <header style="text-align: center;color:black">
   <img src="https://avatars2.githubusercontent.com/u/4621650?s=200&v=4" style="width: 100px;height: 100px">
   <p style="font-size: 20px">[Public Lab] <%= @subject %></p>
+  <p><%= Time.now.strftime("%B %-d %Y") %></p>
 </header>
 
 <div style="width: 46vw;margin: 0 auto;margin-top: 54px;color: black;">
-  <p style="font-size: 1.2em; font-family: sans-serif;margin-bottom: 0;color: lightgray;">Top picks for you</p>
+  <p style="font-size: 1.2em; font-family: sans-serif;margin-bottom: 0;color: lightgray;">Based on what you're following at <a href="https://publiclab.org">PublicLab.org</a></p>
   <hr id="first" style="border: none;height: 1px;background-color: #e2e2e2;margin-bottom: 32px;">
   <table style="font-family: sans-serif;">
     <% @nodes.each do |n| %>
@@ -21,7 +22,7 @@
         </div>
         <div style="margin-top: 20px;">
           <b style="font-weight: 500;"><%= n.author.username.capitalize %></b>
-          <p style="margin: 0;color: #999;font-weight: 500;">Published <%= n.created_at %>.strftime("%m/%d")</p>
+          <p style="margin: 0;color: #999;font-weight: 500;">Published <%= n.created_at.strftime("%B %-d %Y") %></p>
         </div>
         <div <% unless n.main_image.present? %> colspan="2" <% end %> style="padding-bottom: 10px;">
           <p style="font-size: 1.1em;line-height: 1.5;text-align: justify;font-weight: 300;"><%= n.body.truncate(175) %><a href="https://publiclab.org<%= n.path %>" style="text-decoration: none;">  Read more</a></p>
@@ -43,4 +44,4 @@
   </table>
   <p>Click <a href="https://publiclab.org/subscriptions">here</a> to choose your followed topics</p>
   <p>Click <a href="https://publiclab.org/settings">here</a> to change your subscription settings</p>
-</div>
\ No newline at end of file
+</div>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@stoic-plus this one is for you!!! 🎉

@stoic-plus

This comment has been minimized.

Copy link

commented Apr 2, 2019

Thanks so much!

@stoic-plus

This comment has been minimized.

Copy link

commented Apr 13, 2019

Just checking in. I am graduating from a bootcamp this coming Thursday! Very busy but I promise I have not forgotten this and will get to it the following weekend!

@gauravano

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

We will be looking for your PR @stoic-plus!! Thanks 😄 !

@gauravano

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

And, congrats on your bootcamp graduation 🎉

stoic-plus added a commit to stoic-plus/plots2 that referenced this issue Apr 21, 2019

for publiclab#5340 - adds showing current time,formating published ti…
…me,publiclab link to send_digest mailer html

@stoic-plus stoic-plus referenced a pull request that will close this issue Apr 21, 2019

Open

for #5340 - adds showing current time,formating published time,public… #5570

0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.