Planning Issues: Cross Domain Session Management for MK & SWB

[SidharthBansal]

Sequence of workflow:

• Step 1: Review and merge Fix CI spectral-workbench#454
• Step 2: Break the remaining frontend into ftos
  Enhance frontend of providers mapknitter#574 (comment)
  and Frontend for SWB authentication spectral-workbench#448
• Step 3: Review + debug all below PRs
• wait until MK is ready to be published to production and PL Bootstrap is complete
  • ensure exporting works: http://mapknitter-stable.laboratoriopublico.org/maps/test--226
• Step 4: Merge the following prs SIMULTANEOUSLY (after checking them on any branch stable/unstable/local.... I will prefer you to do it on your local )
  • (don't merge yet) Removal of email/username field for MK & SWB #5640
  • (don't merge yet) Cross Domain Session Management at SWB spectral-workbench#450
  • (don't merge yet) Removal of username from Login mapknitter#575

These three prs are dependent. They can't be made independent.

• Step 5: Deploy the changes for MK, SWB and Plots2 on the production SIMULTANEOUSLY.
• Step 5.5 2. copy recaptcha key to production environment file
• Step 6: Check the functionality at the production level.

[jywarren]

Great. Finally getting time to do this fully.

This is really nice:

However, the URL shows: http://localhost:3000/dashboard (which is still plots2). If I manually get the session openid_return_to from the logs, that URL works. But it's not getting inserted properly into the alert. Aha! Here's the bug:

<div class="alert alert-warning"><button type="button" class="close" data-dismiss="alert">×</button><i class="fa fa-exclamation-mark"></i> <i class='icon icon-exclamation-sign'></i> If you registered in order to use <b>SpectralWorkbench.org</b> or <b>MapKnitter.org</b>, <a href=''/openid?openid.claimed_id=http%3A%2F%2Flocalhost%3A3000%2Fopenid%2Fx&openid.identity=http%3A%2F%2Flocalhost%3A3000%2Fopenid%2Fx&openid.mode=checkid_setup&openid.ns=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0&openid.ns.sreg=http%3A%2F%2Fopenid.net%2Fextensions%2Fsreg%2F1.1&openid.realm=http%3A%2F%2Flocalhost%3A3001&openid.return_to=http%3A%2F%2Flocalhost%3A3001%2Fsession%2Fnew%3Fauthenticity_token%3DbMExy9JeRlOIILydAQBlu1%252Fq7Tu9gNtFlgrP979tTQc%253D%26back_to%3D%252F%26return_to%3D%252F&openid.sreg.required=nickname%2Cemail%2Cfullname''>click here to continue &raquo;</a></div>
 ```

[SidharthBansal]

No infinite looping of twitter right now. However, there will be some looping at twitter.

[SidharthBansal]

Noticeable problems:

1. User SIGNS IN at MK OR SWB should result in dashboard at Public Lab. Flash notices are missing
2. Session url missing should not come
3. Redirects to MK page instead of pl.org page
4. Twitter looping for some time(not infinite looping)
5. Recaptcha hash
6. User is redirecting to MK after signing in to SWB or vice versa

[Uzay-G]

Noticeable problems:

1. User SIGNS IN at MK OR SWB should result in dashboard at Public Lab. Flash notices are missing

2. Session url missing should not come

3. Redirects to MK page instead of pl.org page

4. Twitter looping for some time(not infinite looping)

5. Recaptcha hash

6. User is redirecting to MK after signing in to SWB or vice versa

Are these problems people have noticed recently that we need to fix or should we check if they still exist?

[SidharthBansal]

We found these problems few month ago so we need to fix

…

On Fri, 17 Jan 2020, 1:29 am Uzay-G, ***@***.***> wrote: Noticeable problems: 1. User SIGNS IN at MK OR SWB should result in dashboard at Public Lab. Flash notices are missing 2. Session url missing should not come 3. Redirects to MK page instead of pl.org page 4. Twitter looping for some time(not infinite looping) 5. Recaptcha hash 6. User is redirecting to MK after signing in to SWB or vice versa Are these problems people have noticed recently that we need to fix or should we check if they still exist? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5652?email_source=notifications&email_token=AFAAEQ2GZM56WVGLUSN5FKLQ6C4AXA5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJFLAXA#issuecomment-575320156>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQYIHG3LGQXXWUHIJOLQ6C4AXANCNFSM4HKGL2SQ> .

[SidharthBansal]

@VladimirMikulic you can help @Uzay-G here too. I know it is rails stuff and may be complicated for you to handle. But I think we can do it together 😊

[VladimirMikulic]

Thank you for inviting me to the party. I'll be glad to assist you :)

[SidharthBansal]

Lol

…

On Mon, 20 Jan 2020, 9:21 am Vladimir Mikulic, ***@***.***> wrote: Thank you for inviting me to the party. I'll be glad to assist you :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5652?email_source=notifications&email_token=AFAAEQYJMDVSYEZJHW7SE43Q6UNURA5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJLILDQ#issuecomment-576095630>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ6QDOQ2Z2JKHWLBTFLQ6UNURANCNFSM4HKGL2SQ> .

[Uzay-G]

Noticeable problems:

1. User SIGNS IN at MK OR SWB should result in dashboard at Public Lab. Flash notices are missing

2. Session url missing should not come

3. Redirects to MK page instead of pl.org page

4. Twitter looping for some time(not infinite looping)

5. Recaptcha hash

6. User is redirecting to MK after signing in to SWB or vice versa

When you helped me setup the oauth system locally, I saw that 1 and 6 were not a problem. When I logged in or signed up through MK or SWB the redirection was working correctly. What is the problem with no 3?

[SidharthBansal]

I think 3 is solved. Let's focus on the rest then

…

On Tue, 21 Jan 2020, 3:06 am Uzay-G, ***@***.***> wrote: Noticeable problems: 1. User SIGNS IN at MK OR SWB should result in dashboard at Public Lab. Flash notices are missing 2. Session url missing should not come 3. Redirects to MK page instead of pl.org page 4. Twitter looping for some time(not infinite looping) 5. Recaptcha hash 6. User is redirecting to MK after signing in to SWB or vice versa When you helped me setup the oauth system locally, I saw that 1 and 6 were not a problem. When I logged in or signed up through MK or SWB the redirection was working correctly. What is the problem with no 3? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5652?email_source=notifications&email_token=AFAAEQ3WFBE5DVQJKOYX2BLQ6YKNRA5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJN3YCQ#issuecomment-576437258>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ5W4FV52IZXL3SUW3TQ6YKNRANCNFSM4HKGL2SQ> .

[Uzay-G]

Alright 👍. Number 2 is an error when logging in through MK or SWB?

[SidharthBansal]

Yes

…

On Wed, 22 Jan 2020, 3:24 am Uzay-G, ***@***.***> wrote: Alright 👍. Number 2 is an error when logging in through MK or SWB? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5652?email_source=notifications&email_token=AFAAEQ4XDLOILGFKBQTKZ3TQ65VJ3A5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJRM4TQ#issuecomment-576900686>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ3PUM224O7ILQENYBLQ65VJ3ANCNFSM4HKGL2SQ> .

[Uzay-G]

Oh wait. I actually have noticed a problem. I could not find the session error but currently, logging in through MK or SWB with oauth redirects to dashboard. Normal login does not.

I am going to setup the multi-oauth system again locally to see if I have the same problem 👍

[SidharthBansal]

You found the problem. Great! Let's fix this

…

On Wed, Jan 22, 2020 at 12:15 PM Uzay-G ***@***.***> wrote: Oh wait. I actually have noticed a problem. I could not find the session error but currently, logging in through MK or SWB with oauth redirects to dashboard. Normal login does not. I am going to setup the multi-oauth system again locally to see if I have the same problem 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5652?email_source=notifications&email_token=AFAAEQ2T5JMSO4DXLB7MJBDQ67TSJA5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJSNK3A#issuecomment-577033580>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQYTSYYNUZMUGSE4JI3Q67TSJANCNFSM4HKGL2SQ> .

[Uzay-G]

The redirection is working for MK locally. Maybe we haven't deployed to production for fixes to take effect? On Wed, Jan 22, 2020 at 10:33 AM Sidharth Bansal <notifications@github.com> wrote:

…

You found the problem. Great! Let's fix this On Wed, Jan 22, 2020 at 12:15 PM Uzay-G ***@***.***> wrote: > Oh wait. I actually have noticed a problem. I could not find the session > error but currently, logging in through MK or SWB with oauth redirects to > dashboard. Normal login does not. > > I am going to setup the multi-oauth system again locally to see if I have > the same problem 👍 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #5652?email_source=notifications&email_token=AFAAEQ2T5JMSO4DXLB7MJBDQ67TSJA5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJSNK3A#issuecomment-577033580 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AFAAEQYTSYYNUZMUGSE4JI3Q67TSJANCNFSM4HKGL2SQ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5652?email_source=notifications&email_token=AMTREYKYQPZNFUE4EC7B6Z3Q7AHF3A5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJS3UVI#issuecomment-577092181>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMTREYPLBXJFG2MUCWGEZS3Q7AHF3ANCNFSM4HKGL2SQ> .

[SidharthBansal]

Yeah we haven't deployed plots2 yet. You can try to complete the system test task until the GCI deadline. We can come back here again :-) Let's focus on it.

…

On Wed, Jan 22, 2020 at 10:39 PM Uzay-G ***@***.***> wrote: The redirection is working for MK locally. Maybe we haven't deployed to production for fixes to take effect? On Wed, Jan 22, 2020 at 10:33 AM Sidharth Bansal ***@***.*** > wrote: > You found the problem. Great! Let's fix this > > On Wed, Jan 22, 2020 at 12:15 PM Uzay-G ***@***.***> wrote: > > > Oh wait. I actually have noticed a problem. I could not find the session > > error but currently, logging in through MK or SWB with oauth redirects to > > dashboard. Normal login does not. > > > > I am going to setup the multi-oauth system again locally to see if I have > > the same problem 👍 > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < > #5652?email_source=notifications&email_token=AFAAEQ2T5JMSO4DXLB7MJBDQ67TSJA5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJSNK3A#issuecomment-577033580 > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AFAAEQYTSYYNUZMUGSE4JI3Q67TSJANCNFSM4HKGL2SQ > > > > . > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #5652?email_source=notifications&email_token=AMTREYKYQPZNFUE4EC7B6Z3Q7AHF3A5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJS3UVI#issuecomment-577092181 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AMTREYPLBXJFG2MUCWGEZS3Q7AHF3ANCNFSM4HKGL2SQ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5652?email_source=notifications&email_token=AFAAEQZLDRPB2VRP4DIR753Q7B4WFA5CNFSM4HKGL2S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJULSHI#issuecomment-577288477>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ7VLOWPM24OY6AXIMLQ7B4WFANCNFSM4HKGL2SQ> .

[SidharthBansal]

SWB working perfectly fine now. No redirecting back to publiclab.org 🎉

[SidharthBansal]

mapknitter working perfectly fine now 🚀

[Uzay-G]

🚀 🎉