Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend for SWB authentication #448

Closed
SidharthBansal opened this issue Apr 21, 2019 · 5 comments · Fixed by #455
Closed

Frontend for SWB authentication #448

SidharthBansal opened this issue Apr 21, 2019 · 5 comments · Fixed by #455
Labels

Comments

@SidharthBansal
Copy link
Member

As finalised in publiclab/mapknitter#385, @IshaGupta18 is implementing the front end as
image
for MK. We can use the same partial files here at SWB as the code should be exactly the same.
Thanks all

@SidharthBansal
Copy link
Member Author

We will come to this once publiclab/mapknitter#385 is complete @IshaGupta18
I hope this works for you. I think we might be able to create a first timer issue for this one. Do you agree with me?

@SidharthBansal
Copy link
Member Author

I figured out there are some changes in the bootstrap layouts in SWB and MK so this issue is not ideal for fto eventhough code is similar. So, it has to be done by someone.

@IshaGupta18
Copy link
Contributor

Yes @SidharthBansal once the entire login system is complete in MK (with all PRs merged), I would split it up in small FTOs!

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Apr 30, 2019 via email

@IshaGupta18
Copy link
Contributor

@SidharthBansal #455 is my PR for this, kindly take a look at it. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants