Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI implementation project discussion and planning #5739

Closed
7 of 8 tasks
gautamig54 opened this issue May 18, 2019 · 41 comments
Closed
7 of 8 tasks

UI implementation project discussion and planning #5739

gautamig54 opened this issue May 18, 2019 · 41 comments
Labels
discussion gsoc outreachy planning Planning issues! summer-of-code
Projects
UI improvements - Summer Of Code 2019

Comments

@gautamig54
Copy link
Contributor

gautamig54 commented May 18, 2019 •
edited by jywarren

This issue is regarding the planning and discussion for the UI improvement project for summer 2019. This will contain an overview of the project.
The pages to focus on are :

Screen Shot 2019-05-19 at 2 41 35 AM

Screen Shot 2019-05-19 at 4 02 32 AM

  • Individual Tags page

Screen Shot 2019-05-19 at 4 01 34 AM

Screen Shot 2019-05-19 at 4 06 46 AM

  • Profile page

Screen Shot 2019-05-19 at 4 01 10 AM

Screen Shot 2019-05-19 at 4 06 07 AM

  • tag/tag_name page

Screen Shot 2019-05-23 at 5 53 17 PM

Together with these pages, we will be working on other bootstrap fixes on the other pages as well.
cc : @CleverFool77
@gautamig54
Copy link
Contributor Author

@jywarren @gauravano It is a general issue related to UI implementations. We will also be creating separate issues for each page and create a checklist there itself.
@CleverFool77 Kindly add if I missed out something.
Thanks!

@CleverFool77
Copy link
Member

CleverFool77 commented May 19, 2019 •
edited

Hi @gautamig54
I just updated the people section and added some more checklists.
I have started off the assignment.
Could you look at it.
Thanks.

@CleverFool77
Copy link
Member

CleverFool77 commented May 19, 2019 •
edited

I have linked all the issues here of each section in this central planning issue.
Thanks !

@gautamig54
Copy link
Contributor Author

gautamig54 commented May 19, 2019 •
edited

Can we add blogs page and editor in this project as well?
What do you think @CleverFool77 ??
Also, is the design for dashboard ready? I couldn't find it.

@CleverFool77 CleverFool77 mentioned this issue May 19, 2019
Closed
@asquare14
Copy link
Member

@gautamig54 Great work with the issue ! Well-detailed. When you have the designs for dashboard ready link it here ! :)

@CleverFool77
Copy link
Member

Just a bit, I guess there are still some changes going on in design of dashboard.
But no worries. We'll add it eventually.
But till then, we can add the latest design of dashboard yet.
How about that ?
Regarding blogs page and editor page. There are still some people working on them. maybe we should wait for while and if there is no progress, we can add it in our todos and complete it.
Thanks !!!

@gautamig54
Copy link
Contributor Author

gautamig54 commented May 19, 2019 •
edited

Thanks @asquare14!!
@CleverFool77 Sounds great!!!
@jywarren can add the design of the dashboard once it is ready.
Thanks!

@jywarren
Copy link
Member

Just noting - more soon here, sorry! but that the tag page is probably going to be much updated based on the style guide! There's a design at page 8 - what do you think?

https://docs.google.com/presentation/d/1-XHlVn3KQxSjS5WzHgc1l1qvFwqUC5f3-7GXugUP9u4/edit?ts=5cab5403#slide=id.g5926e39f86_0_189

image

It's not completely done, but if you'd like to try copying and refining it in the main Mockups page, that'd be awesome! https://docs.google.com/presentation/d/1TCZoTfuhamRVrUak8aDgqJAwSgyhRtZg2Pgacl2_4zc/edit#slide=id.g558b0e2e98_1_0

@jywarren
Copy link
Member

And, I can't find it right now but I believe there's an issue open for updating the /tags page to Bootstrap 4 as well!

@CleverFool77
Copy link
Member

CleverFool77 commented May 22, 2019 •
edited

And, I can't find it right now but I believe there's an issue open for updating the /tags page to Bootstrap 4 as well!

#5675 This one is tags page update issue.
I pinged the assignee, as soon as there is reply. The work will start on bootstrap upgrade on /tags page.
After that we will work tags description page 'tag/tag_name based on above design.
Thanks !!!

@jywarren
Copy link
Member

jywarren commented May 22, 2019 via email

@gautamig54
Copy link
Contributor Author

I have updated this issue with the tag/tag_name page design. Thanks!

@jywarren
Copy link
Member

Hi all! Your recent changes are live!!! They look great!!!

https://publiclab.org/tags

https://publiclab.org/people

Stay tuned in the chatroom to hear when publications happen - great work!

@milaaraujo
Copy link
Collaborator

This looks good! The project is very well organized.

I have not introduced myself yet, but my name is Camila! I was a participant in Rails Girls Summer of Code in 2018 and since then I have been a contributor to the project. I have worked mostly on the Search API (https://github.com/publiclab/plots2/projects/6 and https://github.com/publiclab/plots2/projects/8). And I will be Lekhika's co-mentor! :)

@CleverFool77, let me know when you need help with anything! And do not hesitate to mention me directly when you need reviews. I'm in Vancouver, so our timezones are very different! But I will do my best to answer as soon as possible.

@asquare14
Copy link
Member

asquare14 commented May 24, 2019 via email

@CleverFool77
Copy link
Member

This looks good! The project is very well organized.

I have not introduced myself yet, but my name is Camila! I was a participant in Rails Girls Summer of Code in 2018 and since then I have been a contributor to the project. I have worked mostly on the Search API (https://github.com/publiclab/plots2/projects/6 and https://github.com/publiclab/plots2/projects/8). And I will be Lekhika's co-mentor! :)

@CleverFool77, let me know when you need help with anything! And do not hesitate to mention me directly when you need reviews. I'm in Vancouver, so our timezones are very different! But I will do my best to answer as soon as possible.

Hey, Nice to meet you.
This is Lekhika @CleverFool77
I would be glad for your help here.

Here is the link of project . I have added some stuff and tried to make it more organised.
https://github.com/publiclab/plots2/projects/10
The project feature of GitHub shows the progress of project very well.
Thanks !!!

@jywarren
Copy link
Member

Hi all! Is there an updated place to list out some refinements and goals for the /tags page? It's looking tremendous. I see a few formatting tweaks perhaps to the way author images are shown:

image

And I know @ebarry has suggested that we hide (by default) topics that include : because these are mostly for utility purposes. Maybe we should show them only if we have a parameter set like params[:all] == true ? And then at some point we can add a ... menu to contain more advanced features like this, that would point at https://publiclab.org/tags?all=true -- what do you think?

@CleverFool77 CleverFool77 mentioned this issue May 27, 2019
Closed
@jywarren
Copy link
Member

jywarren commented Jun 4, 2019

Hi all! Just noting that the individual tag pages are starting to get a bit... extra broken 😂

https://publiclab.org/tag/pi-camera

image

Maybe it's worth bumping up the priority of that project a little bit, or at least implementing a short term fix?

@CleverFool77
Copy link
Member

CleverFool77 commented Jun 4, 2019 via email

@jywarren
Copy link
Member

jywarren commented Jun 4, 2019 via email

@gautamig54
Copy link
Contributor Author

I am working on this one!

@CleverFool77
Copy link
Member

In the features question, the picture is the profile picture of the person who asked the question ?

@CleverFool77
Copy link
Member

I am working on this one!

Did you mean short term fix ? Sure then.
thanks !!

@CleverFool77
Copy link
Member

Hi @gautamig54 It would be great if you can add your work which is done or is in progress in project cards. It would help a lot in checking the work progress. And arrange or sort it with time. So that we can the latest one above.
Thanks !!

@CleverFool77
Copy link
Member

Hi @gautamig54 It would be great if you can add your work which is done or is in progress in project cards. It would help a lot in checking the work progress. And arrange or sort it with time. So that we can the latest one above.
Thanks !!

No worries :3 I already added.

@CleverFool77
Copy link
Member

Just made few arrangements in project for better categorisation of work.
https://github.com/publiclab/plots2/projects/10
Thanks !!

@gautamig54
Copy link
Contributor Author

Hey, I was trying to upload an image to the tag wiki page to check the changes for this issue but wasn't successful. It shows a server error, saying "Could not run the identify command. Please install ImageMagick. excluded from capture: Not configured to send/capture in environment 'development' "
Any suggestions how to resolve this?

@jywarren
Copy link
Member

jywarren commented Jun 6, 2019 via email

@gautamig54
Copy link
Contributor Author

gautamig54 commented Jun 8, 2019 •
edited

Thanks @jywarren I got it working now. I was some macOS issue.

@gautamig54
Copy link
Contributor Author

gautamig54 commented Jun 8, 2019 •
edited

@jywarren Do you want the wiki/tag content below the image like this?

Screen Shot 2019-06-08 at 6 04 26 PM

Or like the divided page where half of it belongs to the picture and half for its content. The problem with that is it works fine with smaller images but with larger images as in https://publiclab.org/tag/pi-camera it writes on the image. In that case we can try resizing the image. What say?
@CleverFool77 would love to listen your thought on this. Thanks!

@CleverFool77
Copy link
Member

Hi @gautamig54 Can you just look into this small bug. The Continue button is going out of card.

Screenshot from 2019-06-08 15-31-14

@gautamig54
Copy link
Contributor Author

@CleverFool77 I'll solve this one. Thanks!

@gautamig54
Copy link
Contributor Author

I have raised a PR for the above bug #5860
Thanks for pointing this!

@jywarren
Copy link
Member

For the quick fix to the /tag/____ page image issue, we originally had the image and text quite small; i think just setting the image to 100% width solves it for now:

image

However, for the broader fix to this page, we should look to the style guide! https://publiclab.org/notes/warren/05-07-2019/introducing-a-draft-style-guide-for-public-lab

@gautamig54
Copy link
Contributor Author

@jywarren Is this fine for the smaller images for now?

Screen Shot 2019-06-11 at 1 02 12 AM

@CleverFool77
Copy link
Member

Hi @jywarren @gautamig54
As we can see that as per the progress of project. People and tags section is almost done. Questions page is 3/4th done i guess. We are working on search section part right now. So should I open a new planning issue for a new section as we can look over the planning and break up parts of the new section while continuing the work on current one. So if yes, which section should be next from dashboard, profile, tags/tag name etc? As there might be priorities regarding sections. And if no, should the section done till now be refined?

@jywarren
Copy link
Member

jywarren commented Jun 13, 2019 via email

@gautamig54
Copy link
Contributor Author

That sounds great @jywarren. I'll open up issues for the individual tags page and the profile page.
Thanks!

@CleverFool77
Copy link
Member

CleverFool77 commented Jun 21, 2019 •
edited

Hi
I published my blog this morning regarding the work for outreachy.
https://medium.com/@lekhikadugtal/my-project-work-for-outreachy-e455974cdb47
Do give it a read <3
cc : @jywarren @gauravano @milaaraujo @rexagod @gautamig54 @Souravirus @cesswairimu

@jywarren
Copy link
Member

jywarren commented Jun 21, 2019 via email

@CleverFool77 CleverFool77 moved this from To do to In progress Issues in UI improvements - Summer Of Code 2019 Jul 5, 2019
@jywarren
Copy link
Member

Closing this as the only things left are the page subheadings, the new dashboard #6072 and the final Questions page #6323

THANKS AND CONGRATS!!!

UI improvements - Summer Of Code 2019 automation moved this from In progress Issues to Done Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion gsoc outreachy planning Planning issues! summer-of-code
Projects
No open projects
UI improvements - Summer Of Code 2019
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jywarren @milaaraujo @asquare14 @CleverFool77 @gautamig54