UI improvements Planning Issue : Searchbar and Search Results page #5708

CleverFool77 · 2019-05-11T17:17:36Z

jywarren · 2019-05-13T16:52:40Z

Hi! This is looking great. I think more is coming via @ebarry but just wanted to note this great search results page design by @IshaGupta18 here:

https://publiclab.org/notes/IshaGupta18/03-22-2019/outreachy-19-proposal-public-lab-ui-improvements#Part+9:+Search+results

We have a page in the shared mockups presentation for search results UI where @ebarry and I built on that design idea a bit too:

This is all a bit more to do with displaying the results rather than the search input form but is still related. Thank you!!!

jywarren · 2019-05-13T19:53:12Z

Also noting relation to #5719!

CleverFool77 · 2019-05-14T14:52:55Z

HI @jywarren
The design of search results UI looks great.
I haven been thinking about results of search, and had similar design UI for that.
I've updated the issue regarding search results UI and added todos checklists.
What I am curious about the searhbar.
Is there gonna be a new minimal search UI like google or we'll have a searchbar in navbar only.

jywarren · 2019-05-14T16:58:39Z

I think we've worried about the redundancy of the navbar search with the in-page search box. What do you think is a good way forward?

…

On Tue, May 14, 2019 at 10:53 AM Lekhika Dugtal ***@***.***> wrote: HI @jywarren <https://github.com/jywarren> The design of search results UI looks great. I haven been thinking about results of search, and had similar design UI for that. I've updated the issue regarding search results UI and added todos checklists. What I am curious about the searhbar. Is there gonna be a new minimal search UI like google or we'll have a searchbar in navbar only. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5708?email_source=notifications&email_token=AAAF6J7PJSLITE2A6SHZWNDPVLG4RA5CNFSM4HMITEL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLXUKY#issuecomment-492272171>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J6LJ4QNIMMQO4NZWULPVLG4RANCNFSM4HMITELQ> .

IshaGupta18 · 2019-05-14T17:01:56Z

Thank you for the appreciation! On Tue, May 14, 2019, 10:28 PM Jeffrey Warren <notifications@github.com> wrote:

…

I think we've worried about the redundancy of the navbar search with the in-page search box. What do you think is a good way forward? On Tue, May 14, 2019 at 10:53 AM Lekhika Dugtal ***@***.***> wrote: > HI @jywarren <https://github.com/jywarren> > The design of search results UI looks great. > I haven been thinking about results of search, and had similar design UI > for that. > I've updated the issue regarding search results UI and added todos > checklists. > What I am curious about the searhbar. > Is there gonna be a new minimal search UI like google or we'll have a > searchbar in navbar only. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #5708?email_source=notifications&email_token=AAAF6J7PJSLITE2A6SHZWNDPVLG4RA5CNFSM4HMITEL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLXUKY#issuecomment-492272171 >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AAAF6J6LJ4QNIMMQO4NZWULPVLG4RANCNFSM4HMITELQ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5708?email_source=notifications&email_token=AJXHQZ34YJEKTJ3RT34WI7TPVLVUHA5CNFSM4HMITEL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVMDZ4A#issuecomment-492322032>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ2BWLEECIIR7LMLA5DPVLVUHANCNFSM4HMITELQ> .

CleverFool77 · 2019-05-18T05:45:55Z

Hi @jywarren ,
Maybe we can just have search option in navbar which would link to another page.
At newpage, we can have minimal search bar like google and we can do various search by option , there itself.
What do you think about this ?

CleverFool77 · 2019-05-18T05:47:36Z

Hi @gautamig54
As I can see gsoc starts later than outeachy and you have exams too.
So I'll begin the work for design. I have done assignments for checklists for myself.
Thanks !!

gautamig54 · 2019-05-18T21:22:49Z

@CleverFool77 I am done with my exams. Let's start with the UI implementation. Let's take it one by one. I will get started with the people's page. Thanks!

CleverFool77 · 2019-05-19T01:03:17Z

Hi @gautmig54 How about we take two issues together. Both people section and questions page sideways. What do you think?
So that if checklists of one section are dependent on each other and we are unable to move forward. At that time, we can work on different checklist from different issue.
But in real, let's take people section first. I'll do the assignment then.
Thanks.

CleverFool77 · 2019-05-19T17:20:44Z

Hi @jywarren @gauravano
I was going through the search results UI section.
I did some chnages to code and did this (below)

Is pill size correct or is there need to chnage this.
Should the design be like this only ? I need suggestion so that I can move forward.
Thanks !!!!

gautamig54 · 2019-05-19T18:54:34Z

@CleverFool77 I think it will look better if you can reduce the pill size and shift the left column downwards.

CleverFool77 · 2019-05-20T07:08:09Z

Hi @gautamig54 So should it be 3/4 of what it is right now ?

Smaller pill size

IshaGupta18 · 2019-05-20T09:19:45Z

Hey this looks pretty great!

gautamig54 · 2019-05-20T10:15:31Z

@CleverFool77 The original width of the pill looks better. Maybe you can try altering the height of the pills and also centre align the text in the them.

CleverFool77 · 2019-06-06T10:54:24Z

Hi @ebarry @jywarren

I was trying out the code, So I wanted to ask instead of search box, I should have Try with Google search link which would have action of google search (Similar to UI which you posted above ) or Should it be just searchbox like below ? And the other results for intra search would be hidden when google search results are shown ?

jywarren · 2019-06-06T14:36:28Z

Hmm, can you show a quick mock-up? I was hoping Google search would seem like the "default" to people for the time being. I think it's a little odd that navbar search would still exist but we could see how it works... it'll offer tag search results and then offer to continue in the Google search with the "view all results" entry, so even if it's a little odd I think people will still be routed eventually back to the full Google search input once they interact with it.

…

On Thu, Jun 6, 2019, 3:55 AM Lekhika Dugtal ***@***.***> wrote: Hi @ebarry <https://github.com/ebarry> @jywarren <https://github.com/jywarren> I was trying out the code, So I wanted to ask instead of search box, I should have Try with Google search link which would have action of google search (Similar to UI which you posted above ) ? And the other results for intra search would be hidden when google search results are shown ? [image: Screenshot from 2019-06-06 16-20-59] <https://user-images.githubusercontent.com/26685258/59027624-22551d80-8877-11e9-846e-1a377a6093a7.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5708?email_source=notifications&email_token=AAAF6J7ZPODP22MJCYYG4TDPZDUGDA5CNFSM4HMITEL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXCPMLI#issuecomment-499447341>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J3LK45HDUR3TJPDRUDPZDUGDANCNFSM4HMITELQ> .

CleverFool77 · 2019-06-06T14:57:12Z

Hi @jywarren
I did add screenshot in comment above.
How do you want Google search to be ? default be like ? Similar to Try your search with Google as it appears in UI and then get the Google results ?
or View All entry be a button leading to action of custom google search

jywarren · 2019-06-06T15:04:48Z

Oh I see, sorry! So, let's try to not show "Google" unless it is a lot of work to remove it. How does that sound?

CleverFool77 · 2019-06-06T15:12:07Z

Ohkk!! I'm still pretty confused about the UI , so I'll show the mockup first then let's see and do the further changes.

ebarry · 2019-06-06T19:22:15Z

Thank you @CleverFool77 !!!

CleverFool77 · 2019-06-13T05:03:43Z

Hi @gautamig54 Can you look over some of the parts for search section here ?
Thanks !!!

gautamig54 · 2019-06-13T05:17:42Z

Sure! I will take up the # of results and the sort by issues.
Sorry for missing this one out.
Thanks!

CleverFool77 · 2019-06-13T14:34:13Z

Hi @jywarren I wanted to ask that as per the documentation https://developers.google.com/custom-search/docs/element, the search can be triggered either through searchbox or url in programmatic execution .
Is searchresults-only tag from componentConfig which is triggered by a <a> tag has Try the search with Google line ?

So we need to execute the params[:query] for which we are doing search, to be executed for google search triggered by id given to above <a>?

jywarren · 2019-06-13T16:37:48Z

the search can be triggered either through searchbox or url in programmatic execution .

Yes, and I think that's what we're doing via the q= param! as in #5708 (comment)

Is searchresults-only tag from componentConfig which is triggered by a tag has Try the search with Google line ?

So we need to execute the params[:query] for which we are doing search, to be executed for google search triggered by id given to above ?

Sorry i'm not quite sure I follow, what are you looking to do? Trigger the search from JavaScript?

jywarren · 2019-06-21T22:11:30Z

Would you like to try making the navbar search go to /search?q=____ instead of /search/_____ now, and replacing the main Content search view with Google search results? We're doing well here so we can start this process now I think.

So we'll need:

make the navbar search go to /search?q=____ instead of /search/_____
replacing the main Content search view with Google search results currently stored in wiki page at https://publiclab.org/w/search
adding related tags based on the query
adding a listener so that as you type new queries, it updates related tags (this will be harder but I have some code for it, and we can do in follow-up!)

How does this sound?

jywarren · 2019-06-21T22:17:59Z

Let's add a few more for the navbar search, if it's OK!

let's show a spinner icon while it loads the autocomplete results! (as shown below) - say, replacing the magnifying glass icon?
Let's change the inline heading "Tags" to "Topics"
let's put the actual tagname in a badge so it's recognizable as a topic...?
can we filter out powertags from the tags autocomplete (@ebarry is this right?)

Would become:

<ul class="typeahead dropdown-menu" role="listbox">
<li class="dropdown-header">TOPICS</li>
<li class="active"><a class="dropdown-item" href="#" role="option"><span style="font-size:100%" class="badge badge-primary">education</span></a></li>

CleverFool77 · 2019-06-25T13:09:08Z

This looks cool. I'll add them to list @jywarren
Hi @rexagod I need help in JavaScript for triggering the Custom Google search with click on link.

rexagod · 2019-06-25T17:43:32Z

Sure thing, @CleverFool77! Can you link me to the code?

CleverFool77 · 2019-06-25T17:49:00Z

#5708 (comment)

I was using the code from the links by @jywarren in the method I wrote. I tried from api documentation to find a method of triggering search without search box and link.
But I'm not sure about the usage of the url part searching without searchbox from documentation

rexagod · 2019-06-27T09:46:56Z

But I'm not sure about the usage of the url part searching without searchbox from documentation

Hello, @CleverFool77. I take it that the parameter search implementation is what's causing the problem here?

If that's the case, how about attaching an onload listener for window.location.href and parse that for parameters then use those parameters to trigger a search (the same way you do for onclick for the searchbar)?

What do you think?

CleverFool77 · 2019-06-27T09:52:47Z

Thank you so much @rexagod
Yes I guess this method will work, I'll try it out 🤔
Thanks 😃

jywarren · 2019-08-26T20:29:02Z

Done here!!! Yay!

ebarry · 2019-08-26T20:58:54Z

AMAZING!!!!!!!! The new Search Bar is working great and it's so fun to use! -- +1 336-269-1539 / @lizbarry <http://twitter.com/lizbarry> / lizbarry.net

…

On Mon, Aug 26, 2019 at 4:29 PM Jeffrey Warren ***@***.***> wrote: Closed #5708 <#5708>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5708?email_source=notifications&email_token=AABHNH6TUSSPDHQCF4S67I3QGQ4JHA5CNFSM4HMITEL2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTIJJGYI#event-2584908641>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABHNH6T6H7Y724S6NKY2Y3QGQ4JHANCNFSM4HMITELQ> .

CleverFool77 added gsoc outreachy summer-of-code labels May 11, 2019

CleverFool77 added this to To do in UI improvements - Summer Of Code 2019 May 11, 2019

CleverFool77 added the design issue requires more design work and discussion (i.e. mockups and sketches) label May 11, 2019

ebarry added this to the Search improvements milestone May 13, 2019

jywarren mentioned this issue May 13, 2019

Tag search improvements #5719

Closed

4 tasks

CleverFool77 mentioned this issue May 14, 2019

UI Improvements Planning Issue : People Section #5707

Closed

8 tasks

CleverFool77 closed this as completed May 18, 2019

UI improvements - Summer Of Code 2019 automation moved this from To do to Done May 18, 2019

CleverFool77 reopened this May 18, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress May 18, 2019

gautamig54 mentioned this issue May 19, 2019

UI implementation project discussion and planning #5739

Closed

8 tasks

CleverFool77 mentioned this issue May 19, 2019

Weekly Community Check-In #22 - "What was your Eureka moment?" publiclab/image-sequencer#1065

Closed

gautamig54 changed the title ~~UI improvements Planning Issue : Searchbar~~ UI improvements Planning Issue : Searchbar and Search Results page May 19, 2019

CleverFool77 mentioned this issue May 20, 2019

Column tab in search results page #5747

Closed

5 tasks

jywarren closed this as completed in #5851 Jun 6, 2019

UI improvements - Summer Of Code 2019 automation moved this from To do to Done Jun 6, 2019

CleverFool77 reopened this Jun 6, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress Jun 6, 2019

CleverFool77 moved this from In progress to In progress Issues in UI improvements - Summer Of Code 2019 Jun 6, 2019

This was referenced Jun 18, 2019

Stats Page Query Bug #5917

Open

Search typeahead two words or more bug #4601

Closed

Narrow TypeaheadService search to just the most recent revision of each Node #3381

Closed

CleverFool77 mentioned this issue Jul 5, 2019

[WIP] SearchResults: Add custom google search results #5978

Closed

jywarren closed this as completed Aug 26, 2019

UI improvements - Summer Of Code 2019 automation moved this from In progress Issues to Done Aug 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI improvements Planning Issue : Searchbar and Search Results page #5708

UI improvements Planning Issue : Searchbar and Search Results page #5708

CleverFool77 commented May 11, 2019 •

edited

Loading

jywarren commented May 13, 2019

jywarren commented May 13, 2019

CleverFool77 commented May 14, 2019

jywarren commented May 14, 2019 via email

IshaGupta18 commented May 14, 2019 via email

CleverFool77 commented May 18, 2019

CleverFool77 commented May 18, 2019

gautamig54 commented May 18, 2019

CleverFool77 commented May 19, 2019 •

edited

Loading

CleverFool77 commented May 19, 2019 •

edited

Loading

gautamig54 commented May 19, 2019

CleverFool77 commented May 20, 2019 •

edited

Loading

IshaGupta18 commented May 20, 2019

gautamig54 commented May 20, 2019

CleverFool77 commented Jun 6, 2019 •

edited

Loading

jywarren commented Jun 6, 2019 via email

CleverFool77 commented Jun 6, 2019

jywarren commented Jun 6, 2019

CleverFool77 commented Jun 6, 2019

ebarry commented Jun 6, 2019

CleverFool77 commented Jun 13, 2019

gautamig54 commented Jun 13, 2019

CleverFool77 commented Jun 13, 2019

jywarren commented Jun 13, 2019

jywarren commented Jun 21, 2019

jywarren commented Jun 21, 2019 •

edited

Loading

CleverFool77 commented Jun 25, 2019

rexagod commented Jun 25, 2019

CleverFool77 commented Jun 25, 2019 •

edited

Loading

rexagod commented Jun 27, 2019 •

edited

Loading

CleverFool77 commented Jun 27, 2019

jywarren commented Aug 26, 2019

ebarry commented Aug 26, 2019 via email

UI improvements Planning Issue : Searchbar and Search Results page #5708

UI improvements Planning Issue : Searchbar and Search Results page #5708

Comments

CleverFool77 commented May 11, 2019 • edited Loading

Searchbar

Search Results

jywarren commented May 13, 2019

jywarren commented May 13, 2019

CleverFool77 commented May 14, 2019

jywarren commented May 14, 2019 via email

IshaGupta18 commented May 14, 2019 via email

CleverFool77 commented May 18, 2019

CleverFool77 commented May 18, 2019

gautamig54 commented May 18, 2019

CleverFool77 commented May 19, 2019 • edited Loading

CleverFool77 commented May 19, 2019 • edited Loading

gautamig54 commented May 19, 2019

CleverFool77 commented May 20, 2019 • edited Loading

IshaGupta18 commented May 20, 2019

gautamig54 commented May 20, 2019

CleverFool77 commented Jun 6, 2019 • edited Loading

jywarren commented Jun 6, 2019 via email

CleverFool77 commented Jun 6, 2019

jywarren commented Jun 6, 2019

CleverFool77 commented Jun 6, 2019

ebarry commented Jun 6, 2019

CleverFool77 commented Jun 13, 2019

gautamig54 commented Jun 13, 2019

CleverFool77 commented Jun 13, 2019

jywarren commented Jun 13, 2019

jywarren commented Jun 21, 2019

jywarren commented Jun 21, 2019 • edited Loading

CleverFool77 commented Jun 25, 2019

rexagod commented Jun 25, 2019

CleverFool77 commented Jun 25, 2019 • edited Loading

rexagod commented Jun 27, 2019 • edited Loading

CleverFool77 commented Jun 27, 2019

jywarren commented Aug 26, 2019

ebarry commented Aug 26, 2019 via email

CleverFool77 commented May 11, 2019 •

edited

Loading

CleverFool77 commented May 19, 2019 •

edited

Loading

CleverFool77 commented May 19, 2019 •

edited

Loading

CleverFool77 commented May 20, 2019 •

edited

Loading

CleverFool77 commented Jun 6, 2019 •

edited

Loading

jywarren commented Jun 21, 2019 •

edited

Loading

CleverFool77 commented Jun 25, 2019 •

edited

Loading

rexagod commented Jun 27, 2019 •

edited

Loading