For moderator accounts, add ability to turn off email at /settings

[ebarry]

Please describe the desired behavior.

This feature request is part of improving the moderators workflow, and was written with @jywarren and @bronwen9.

This feature request is to add the ability to turn of moderator emails per user at /settings.

This feature should only be shown to /moderators and /admins.

Additional context (optional)

Thanks!

[jywarren]

Copying in line numbers and info from previous issue at #4543 !

Also noting link to VERY similar/related issue at #6867, especially with regard to UI changes that'd need to happen.

---

• Let's add a toggle to https://publiclab.org/settings that:
• when sending moderator emails, causes the site to check user.has_tag('block-node-moderation-emails') before adding that moderator to the list.

The moderators to be notified are collected up in these sections here:

plots2/app/mailers/admin_mailer.rb

Lines 8 to 19 in 3267de0

	def notify_node_moderators(node)
	subject = '[New Public Lab poster needs moderation] ' + node.title
	@node = node
	@user = node.author
	@footer = feature('email-footer')
	moderators = User.where(role: %w(moderator admin)).collect(&:email)
	mail(
	to: "moderators@#{ActionMailer::Base.default_url_options[:host]}",
	bcc: moderators,
	subject: subject
	)
	end

We could add lines like:

all_moderators = User.where(role: %w(moderator admin)).collect(&:email)
moderators = []
all_moderators.each do |mod_user|
  moderators << mod_user unless .has_tag('no-moderation-emails')
end

This would be a great FTO!

Follow-ups would be:

1. write a test for this by adding such a user tag to a testing user account
2. develop a UI for this at the /settings page, as in Option to not receive email notifications for topics you follow #6867

---

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

---

[anthony-zhou]

I'd be happy to work on this as part of GCI. I will open a PR addressing this soon.

[jywarren]

That would be super!!!!

…

On Thu, Jan 9, 2020 at 6:57 PM anthony-zhou ***@***.***> wrote: I'd be happy to work on this as part of GCI. I will open a PR addressing this soon. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6282?email_source=notifications&email_token=AAAF6JZYNEW5TM6OULH3UZ3Q462WZA5CNFSM4IWJSI4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEISGQWI#issuecomment-572811353>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J46HY4OIF65EEV2B7DQ462WZANCNFSM4IWJSI4A> .

[SidharthBansal]

Published on GCI

[jywarren]

Completed by @anthony-zhou ! Thank you!!!