Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change script path in map dependancies to match with LEL #6978

Closed
5 tasks
crisner opened this issue Dec 16, 2019 · 5 comments
Closed
5 tasks

Change script path in map dependancies to match with LEL #6978

crisner opened this issue Dec 16, 2019 · 5 comments
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@crisner
Copy link
Contributor

crisner commented Dec 16, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _mapDependencies.html.erb in the plots2 repository .

See this page for some help in taking your first steps!

Remove the line here:

https://github.com/publiclab/plots2/blob/3f239088f6028b2e87668f7cd9076295dfe4e79d/app/views/map/_mapDependencies.html.erb#L20-L21

and add:

<%= javascript_include_tag('/lib/leaflet-environmental-layers/lib/glify.js') %>
<%= javascript_include_tag('/lib/leaflet-environmental-layers/lib/leaflet-fullUrlHash.js') %>

to match what we currently have on the leaflet environmental layers library.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@crisner crisner added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Dec 16, 2019
@crisner
Copy link
Contributor Author

crisner commented Dec 16, 2019

@sagarpreet-chadha, here's the issue to update the script paths.

@bearkruz
Copy link
Contributor

👋- Could I work on this?

@crisner
Copy link
Contributor Author

crisner commented Dec 21, 2019

Yes. Please, go ahead. 🙂

jywarren pushed a commit that referenced this issue Jan 9, 2020
* Change script path in map dependancies to match with LEL #6978

* change #1

* change #2

* update to original task

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.0.6 to 2.1.7.
- [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases)
- [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

* Update dependency path

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Bear Kruz <16524769+bearkruz@users.noreply.github.com>
Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this issue Jan 14, 2020
* Change script path in map dependancies to match with LEL publiclab#6978

* change #1

* change #2

* update to original task

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.0.6 to 2.1.7.
- [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases)
- [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

* Update dependency path

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Bear Kruz <16524769+bearkruz@users.noreply.github.com>
@sanjana091001
Copy link
Member

Has this issue been fixed or can I work on this?

@crisner
Copy link
Contributor Author

crisner commented Jan 20, 2020

This issue has been fixed. Thanks!

@crisner crisner closed this as completed Jan 20, 2020
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this issue Feb 1, 2020
* Change script path in map dependancies to match with LEL publiclab#6978

* change publiclab#1

* change publiclab#2

* update to original task

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.0.6 to 2.1.7.
- [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases)
- [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump leaflet-environmental-layers from 2.0.6 to 2.1.7

* Update dependency path

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Bear Kruz <16524769+bearkruz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

No branches or pull requests

3 participants