Map floats over the footer while scrolling! - UI Bug

[wajeehamushtaq]

Fixes #10306
I try to fix the Map floats over the footer while scrolling! - UI Bug (1/3). The problem arise due to leaflet map styling. The position is set to absolute so this will create the problem.

[gitpod-io]

[codecov]

Codecov Report

Merging #10358 (8a4bb4d) into main (994d0b4) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 8a4bb4d differs from pull request most recent head 1323436. Consider uploading reports for the commit 1323436 to get more accurate results

@@            Coverage Diff             @@
##             main   #10358      +/-   ##
==========================================
- Coverage   82.11%   81.99%   -0.12%     
==========================================
  Files          98       98              
  Lines        5982     5982              
==========================================
- Hits         4912     4905       -7     
- Misses       1070     1077       +7     

Impacted Files	Coverage Δ
app/services/execute_search.rb	88.88% <0.00%> (-5.56%)	⬇️
app/api/srch/search.rb	66.87% <0.00%> (-3.83%)	⬇️

[wajeehamushtaq]

Hi @jywarren, I have followed your steps. Is it fine now?

[codeclimate]

Code Climate has analyzed commit 1323436 and detected 0 issues on this pull request.

View more on Code Climate.

[jywarren]

/rebase

[jywarren]

This looks really good, my apologies for missing it in my notifications! Just rebasing to get past the test issues, which i think are unrelated. Let's see! 🤞

[jywarren]

Hi, would you mind rebasing this over the latest main branch? i can't seem to do it easily from my end. That will resolve the test! Apologies and thanks!

[wajeehamushtaq]

Hi @jywarren , Can you please guide me about rebasing it to the main branch? Thank you!

[jywarren]

Hi @wajeehamushtaq of course, sorry for the slow response!

---

It looks like you need to rebase your work on top of the latest main. You can do that by following the process outlined here, but you may be able to skip step 2 if your main is still in sync with publiclab's main: https://publiclab.org/wiki/contributing-to-public-lab-software#Rewinding+the+master+branch

In general there are more tips and guides on rebasing here: https://publiclab.org/wiki/developers#Resources

Thanks!

[Tlazypanda]

Hey @wajeehamushtaq feel free to ping in case you are running into any issues. We are here to help ✌️

[cesswairimu]

Hi @wajeehamushtaq, we are unable to move forward without a rebase here, we understand you might be busy and engaged on other things. The solution was great and I will use the solution to convert the issue to a first-timer issue - thanks for working on this. Please feel free to come back anytime and ask for another issue to work on. Closing this. Thanks all