Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invite involment in wiki pages via notices - fixes #106 #1356

Conversation

aspriya
Copy link
Collaborator

@aspriya aspriya commented Mar 25, 2017

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@PublicLabBot
Copy link

PublicLabBot commented Mar 25, 2017

2 Messages
📖 @aspriya Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution!
📖 You have added multiple commits. It’s helpful to squash them if the individual changes are small.

Generated by 🚫 Danger

@@ -22,6 +22,10 @@

<div class="row">

<% if @node.latest.created_at < Time.now - 6.months %>
<div class="alert alert-info" role="alert">This wiki page hasn't been edited for quite long. Consider updating it if you are acquainted with it</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have this text say:

This wiki page hasn't been edited for a while. If you see anything that needs updating, please help out!

Thank you, and apologies for changing the requested text.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure no problem @jywarren. Will do. thanks 👍

@jywarren jywarren changed the title #106 invite involment in wiki pages via notices invite involment in wiki pages via notices - fixes #106 Mar 28, 2017
@jywarren
Copy link
Member

Perfect, thanks a lot!!!

@jywarren jywarren merged commit 91841da into publiclab:master Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants