Added question prompt on dashboard (Fixes #2401) #2431
Conversation
used bootstrap panel to add question prompt on dashboard and also modified Ask Question button
|
hi @amitsin6h just keep the part you wanted to in _sidebar.html.erb by editing the file using resolve conflicts button and after that Travis test would continue. |
|
@Gauravano could you please look now |
Generated by 🚫 Danger |
|
hi @amitsin6h please add the screenshot of the new view.Thanks. |
|
@Gauravano screen shot of Ask a question |
|
This looks good! Do you think we could replace the discussion lists tab in
the sidebar with an "Ask a Question" tab, and make it the default tab? I'm
interested in how to make this a bit more compact and we're planning to get
rid of the discussion tab anyways. What do you think?
Thanks!!!!
…On Tue, Mar 6, 2018, 1:22 AM Amit singh ***@***.***> wrote:
[image: screenshot from 2018-03-06 12-49-48]
<https://user-images.githubusercontent.com/12906090/37019093-ed7e8c88-213c-11e8-8c92-eb88ee39b441.png>
@Gauravano <https://github.com/gauravano> screen shot of *Ask a question*
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2431 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_Urw-EANkpRj0l2KvpSZe3lfNKmks5tbjkfgaJpZM4SbBeC>
.
|
|
@jywarren thats great and we can add wiki on the top navigation bar. Reason to do this because it will be directly visible to the user whoever login and can read wiki. I have also visited the wiki page and saw that it has stuffs like Getting Started , Media , Licenses etc . And according to me keeping wiki in top navigation bar would be great implementation to the dashboard. And we will attach discussion list with ask question. Let me know what you think about this ?? |
|
Sounds good -- so let's do this first, replacing discussion with Ask a
Question, and then we can think about visibility for the wiki pages after.
Thank you!!!
…On Wed, Mar 7, 2018 at 8:20 AM, Amit singh ***@***.***> wrote:
@jywarren <https://github.com/jywarren> thats great and we can add *wiki*
on the top navigation bar. Reason to do this because it will be directly
visible to the user whoever login and can read wiki. I have also visited
the wiki page and saw that it has content like *Getting Started , Donate
, etc* . And according to me keeping *wiki* in top navigation bar would
be great implementation to the dashboard.
And we will attach *discussion list* with *ask question*.
Let me know about this ??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2431 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7YoAvyD0y-WPbtTPojT2pfhqOVqks5tb96QgaJpZM4SbBeC>
.
|
|
@jywarren is it ok now ? also implementing card design will give great look to this sidebar. what you say ? |
|
@jywarren if it looks good then let me know. I will make the PR |
| @@ -1,5 +1,57 @@ | |||
| <br /> | |||
| <br /> | |||
| <div class="panel panel-default"> | |||
There was a problem hiding this comment.
Hi - this is looking real good -- but do you think you could make the indentation really consistent here? It makes it a lot easier to read and helps keep our code clean in the future. Thank you!!!
| <h1 class="panel-title">Ask a question</h1> | ||
| </div> | ||
| <div class="panel-body"> | ||
| <p>The easiest way to start with Public Lab community is to ask a question.<br />See questions and ask your own here:</p> |
There was a problem hiding this comment.
I think this could be two separate <p>s instead of using a br -- do you think you could make that small change? Thanks!!!
|
|
||
| </div> | ||
|
|
||
| <div class="tab-pane" id="lists"> |
There was a problem hiding this comment.
Do we need the lists content here? I think it was removed in a previous project. Be sure to update your master branch before adding new work to it, or older changes will creep back into your code like this!
For now, compare to the latest publiclab/plots2 master branch's file to see what's been removed, and let's update this to match, sound good?
amitsin6h
force-pushed
the
question-prompt
branch
from
b9ed6f8
to
ae06b61
Compare
|
@jywarren could you please review it. |
|
This looks fantastic. Thanks so much for doing this so thoroughly!!! |
…2431) * Added question prompt on dashboard (Fixes publiclab#2401) used bootstrap panel to add question prompt on dashboard and also modified Ask Question button * updated _sidebar.html.erb
Used bootstrap panel to add question prompt on dashboard and also modified Question button as large button was not looking good.