New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.search to add Boolean mode #2547

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jywarren
Contributor

jywarren commented Mar 26, 2018

No description provided.

jywarren added some commits Mar 26, 2018

@PublicLabBot

This comment has been minimized.

PublicLabBot commented Mar 26, 2018

1 Error
🚫 There was a test error at: Failure: test_node_mysql_native_fulltext_search(Minitest::Result) [/usr/local/bundle/gems/mysql2-0.3.21/lib/mysql2/client.rb:80]: ActiveRecord::StatementInvalid: Mysql2::Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ‘MODE))’ at line 1: SELECT node_revisions.nid, node_revisions.body, node_revisions.title, MATCH(node_revisions.body, node_revisions.title) AGAINST(‘organizers’ IN NATURAL LANGUAGE MODE) AS score FROM ‘node_revisions’ WHERE (MATCH(node_revisions.body, node_revisions.title) AGAINST(‘organizers’ IN natural MODE)) app/models/node.rb:39:in ‘search’ test/unit/node_test.rb:26:in ‘block in '
2 Messages
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@ebarry

This comment has been minimized.

Member

ebarry commented Mar 26, 2018

🎊 🐸 🎀 🕺 🥇 🌻 😃 🌷 🦁 💥 🌴

@milaaraujo

This comment has been minimized.

Collaborator

milaaraujo commented Sep 1, 2018

Since this PR had been open for a long time we knew we would have to rebase the code, but we found it easier to open a new PR using the current master code. Moved to #3282.

@milaaraujo milaaraujo closed this Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment