migration for changing following to true for all rows of NodeSelection

[grvsachdeva]

Part 2 of #1610

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in a uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[plotsbot]

	1 Warning
⚠️	New migrations added. Please update schema.rb.example by overwriting it with a copy of the up-to-date db/schema.rb. Also, be aware to preserve the MySQL-specific conditions for full-text indices.

	1 Message
📖	@gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[grvsachdeva]

@jywarren after publishing this please let me know whether all NodeSelections rows have following = true or not. Thanks!

[jywarren]

OK, i'll run NodeSelection.where(following: true).count!

[grvsachdeva]

You mean NodeSelection.where(following: false).count as we need to ensure that there are 0 nodeSelection entries with following = false

[grvsachdeva]

Thanks!

[jywarren]

Great, NodeSelection.where(following: false).count returned 0!

[grvsachdeva]

Awesome 🎉 ! Creating PR for completing this setting then. Thanks!

[jywarren]

This is published!

[grvsachdeva]

Hi @jywarren! Hope you had great vacations. Good to see you back. Sorry, I wasn't able to complete my last setting until now, due to the college placement going on. I will try to complete it as soon as I get some free time. Thanks!

[jywarren]

ok, and good luck! Thanks, it's good to be back in touch with you all.

…

On Wed, Aug 29, 2018 at 1:02 PM Gaurav Sachdeva ***@***.***> wrote: Hi @jywarren <https://github.com/jywarren>! Hope you had great vacations. Good to see you back. Sorry, I wasn't able to complete my last setting until now, due to the college placement going on. I will try to complete it as soon as I get some free time. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3201 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJyce6YutYx0xz7JQKhcswwv8WFnlks5uVskJgaJpZM4VvJ6e> .