Removed "schedule" statement from pull_request_template #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jywarren @SidharthBansal please review |
SidharthBansal
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Hi, changes looks good to me. Thanks for your work.
@jywarren can you please review this and merge this?
Generated by 🚫 Danger |
|
Awesome. Thanks!!!! |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Add "Reply to this email to post a response" to various email templates Fixes publiclab#3323 * Update notify.html.erb * removed "=" from header fixes publiclab#3487 * Delete notify.html.erb * removed = * removed = * Fixes publiclab#3622 shifted "Fixes #[Add issue number here.]" to the top of pull_request_template * fixes publiclab#3649 Removed "schedule" statement from pull_request_template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3649
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!