Date range selector for stats #4302

cesswairimu · 2018-12-14T19:41:12Z

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
ask @publiclab/reviewers for help, in a comment below

plotsbot · 2018-12-14T19:52:39Z

	2 Messages
📖	@cesswairimu Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

jywarren · 2018-12-14T20:38:01Z

Ooh! Very cool! Screenshots? Thanks, Cess!

cesswairimu · 2018-12-14T21:10:11Z

Here it is @jywarren.
Also I realized the footer in this page looks weird. https://publiclab.org/stats/range/ not same as https://publiclab.org/stats. Should it be like this or should I try and fix it? Thanks

jywarren · 2018-12-14T22:49:58Z

Hmm, maybe there's a not-closed HTML tag? A fix would be great!

…

On Fri, Dec 14, 2018 at 4:10 PM Cess ***@***.***> wrote: [image: range2] <https://user-images.githubusercontent.com/17081074/50027442-57d22a00-fffd-11e8-9c44-3c3032f50f71.png> Here it is @jywarren <https://github.com/jywarren>. Also I realized the footer in this page looks weird. https://publiclab.org/stats/range/ not same as https://publiclab.org/stats. Should it be like that or should I try and fix it? Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4302 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwsFkIcSa6ZFthtHRF5Y9mdCPPheks5u5BO0gaJpZM4ZUKUy> .

cesswairimu · 2018-12-14T22:50:30Z

Actually, found the bug on the footer, it was a missing '/' in a closing table tag 😄 It's fixed

jywarren · 2018-12-14T22:58:57Z

This is great. I'm thinking also we might have a way to auto-select some useful date ranges, like "Past 7 days" or "Past month" and such. See how in this date chooser, those are offered at the top? We could start with just a few as buttons:

But that can be in follow-up to this PR. Is this ready to merge? So great!!!!! 👍

cesswairimu · 2018-12-14T23:07:36Z

I have it default selected start for DateTime.now-1.weeks and end DateTime.now. Yeah the selector looks awesome. I will have implement that on this PR. Thanks

cesswairimu · 2018-12-22T20:21:33Z

jywarren · 2018-12-23T18:31:22Z

Hi, @cesswairimu ! CodeClimate is warning us about something here; would you mind clicking the icon above the notice to learn about what it's objecting to? It may be a security issue, but let's just be sure:

https://codeclimate.com/github/publiclab/plots2/pull/4302 -- if it doesn't seem critical, we could in theory ignore it.

Thanks! Otherwise this looks lovely. Maybe we could get the "Today" to align a bit better in the blue button, and add a 2-3px padding inside that button? Let me take a look at the code driving it.

Once we resolve this CodeClimate issue we should be good to go.

jywarren · 2018-12-23T18:33:43Z

app/views/stats/range.html.erb

+        <p>
+            <button data-placement="bottom" data-toggle="popover" data-container="body" data-placement="bottom" type="button" data-html="true" class="btn btn-primary">
+                <span><i class="fa fa-calendar fa-2x"> </i> Today </span> </button>
+             </button>   Compared to  <%= Date.today.to_formatted_s(:long) %>


Ah, here maybe there is a 2nd redundant button element causing trouble? Also, is the span totally necessary? It might be causing some layout issues too... just not totally sure it's required. Thanks!

jywarren · 2018-12-23T18:34:12Z

app/views/stats/range.html.erb

+<h4><b> Select a range below to view stats within the range </b></h4>
+<%= form_tag request.url, method: 'get' do %>
+    <div class="row">
+    <div class="col-md-8" style="background:#F5F6F8;">


Here you could use the well css class from Bootstrap instead of a background css style. Take a look!

https://getbootstrap.com/docs/3.3/

jywarren · 2018-12-23T18:34:51Z

app/views/stats/range.html.erb

+    <h5> Date Range </h5>
+    <%= select_tag :options, options_for_select(["Week", "Month","Year"]), prompt: "View stats in the past", class: " form-control input-lg", onchange: "this.form.submit();" %>
+        </div>
+        </div>


I know it's a bit overly detailed to ask, but if you could keep all the indentations really consistent it does pay off in the long run across our whole project. Thanks, @cesswairimu !!!

cesswairimu · 2018-12-26T15:35:16Z

removed the today from the calendar icon and moved the range details to the calendar icon. Made more sense to me this way because the range changes and would not be compared with today. How does this look?

jywarren · 2018-12-26T15:43:57Z

It looks good but perhaps we could use the bootstrap label styles for the form input labels? What do you think? Thanks!

…

On Wed, Dec 26, 2018, 10:35 AM Cess ***@***.*** wrote: [image: refac] <https://user-images.githubusercontent.com/17081074/50449727-211fdc00-093a-11e9-9fc1-3d844252093d.png> removed the today from the calendar icon and moved the range details to the calendar icon. Made more sense to me this way because the range changes and would not be compared with today. How does this look? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4302 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJzzxQtViEZI2ChKUTroznb4SbNBIks5u85c0gaJpZM4ZUKUy> .

cesswairimu · 2018-12-26T15:44:42Z

Cool on it. Thanks

cesswairimu · 2018-12-26T17:12:14Z

jywarren · 2018-12-27T19:12:19Z

Looks fantastic. Merging this now!!!

* date-range selector for range * fix a missing '/' in table * style calendar selector

ghost assigned cesswairimu Dec 14, 2018

ghost added the in progress label Dec 14, 2018

cesswairimu changed the title ~~Date range selector for stats~~ (WIP)Date range selector for stats Dec 14, 2018

date-range selector for range

69b6b9f

cesswairimu force-pushed the date-range-selector-for-stats branch from fe538ed to 69b6b9f Compare December 14, 2018 22:30

fix a missing '/' in table

1e8e38f

cesswairimu changed the title ~~(WIP)Date range selector for stats~~ Date range selector for stats Dec 14, 2018

jywarren mentioned this pull request Dec 23, 2018

Weekly Community Check-In #2 - "Everybody Struggles"! #4369

Closed

jywarren reviewed Dec 23, 2018

View reviewed changes

cesswairimu force-pushed the date-range-selector-for-stats branch 4 times, most recently from 5fbc450 to a96fe2b Compare December 26, 2018 14:41

style calendar selector

c4b701a

cesswairimu force-pushed the date-range-selector-for-stats branch from a96fe2b to c4b701a Compare December 26, 2018 17:09

jywarren approved these changes Dec 27, 2018

View reviewed changes

jywarren merged commit 14cc431 into publiclab:master Dec 27, 2018

ghost removed the in progress label Dec 27, 2018

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019

Date range selector for stats (publiclab#4302)

3ec19f3

* date-range selector for range * fix a missing '/' in table * style calendar selector

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Date range selector for stats #4302

Date range selector for stats #4302

cesswairimu commented Dec 14, 2018 •

edited

plotsbot commented Dec 14, 2018 •

edited

jywarren commented Dec 14, 2018

cesswairimu commented Dec 14, 2018 •

edited

jywarren commented Dec 14, 2018 via email

cesswairimu commented Dec 14, 2018 •

edited

jywarren commented Dec 14, 2018

cesswairimu commented Dec 14, 2018

cesswairimu commented Dec 22, 2018

jywarren commented Dec 23, 2018

jywarren Dec 23, 2018

jywarren Dec 23, 2018

jywarren Dec 23, 2018

cesswairimu commented Dec 26, 2018

jywarren commented Dec 26, 2018 via email

cesswairimu commented Dec 26, 2018 •

edited

cesswairimu commented Dec 26, 2018

jywarren commented Dec 27, 2018

Date range selector for stats #4302

Date range selector for stats #4302

Conversation

cesswairimu commented Dec 14, 2018 • edited

plotsbot commented Dec 14, 2018 • edited

jywarren commented Dec 14, 2018

cesswairimu commented Dec 14, 2018 • edited

jywarren commented Dec 14, 2018 via email

cesswairimu commented Dec 14, 2018 • edited

jywarren commented Dec 14, 2018

cesswairimu commented Dec 14, 2018

cesswairimu commented Dec 22, 2018

jywarren commented Dec 23, 2018

jywarren Dec 23, 2018

Choose a reason for hiding this comment

jywarren Dec 23, 2018

Choose a reason for hiding this comment

jywarren Dec 23, 2018

Choose a reason for hiding this comment

cesswairimu commented Dec 26, 2018

jywarren commented Dec 26, 2018 via email

cesswairimu commented Dec 26, 2018 • edited

cesswairimu commented Dec 26, 2018

jywarren commented Dec 27, 2018

cesswairimu commented Dec 14, 2018 •

edited

plotsbot commented Dec 14, 2018 •

edited

cesswairimu commented Dec 14, 2018 •

edited

cesswairimu commented Dec 14, 2018 •

edited

cesswairimu commented Dec 26, 2018 •

edited