Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort option is changed according to the new UI #5176

Closed
wants to merge 1 commit into from

Conversation

divyabaid16
Copy link
Contributor

Fixes #5090 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshot for the same:

Selection_080

Thanks!

@plotsbot
Copy link
Collaborator

1 Message
📖 @divyabaid16 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@divyabaid16
Copy link
Contributor Author

@jywarren @gauravano please review this

@jywarren
Copy link
Member

Hi! This looks great. Would you mind uploading a gif to show how it works when you click them? Thank you!!!

@ananyaarun
Copy link
Member

@divyabaid16 , Maybe this can be closed ? Considering another PR is opened :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants