Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort option is changed according to the new UI #5239

Merged
merged 1 commit into from Mar 31, 2019

Conversation

divyabaid16
Copy link
Contributor

Fixes #5090 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

GIF for the change:
Peek 2019-03-24 12-20

Thanks!

@divyabaid16
Copy link
Contributor Author

Created another pull request #5176 since the master branch was updated.

@plotsbot
Copy link
Collaborator

1 Message
📖 @divyabaid16 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@divyabaid16
Copy link
Contributor Author

@jywarren can you please review this?

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gauravano, is this ok in the locales?

Otherwise looks great!!!

@jywarren jywarren merged commit 1afdcda into publiclab:master Mar 31, 2019
@grvsachdeva
Copy link
Member

Yes, @jywarren it's fine. Thanks!

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants