Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column tab in search results page #5747

Closed
wants to merge 1 commit into from
Closed

Column tab in search results page #5747

wants to merge 1 commit into from

Conversation

CleverFool77
Copy link
Member

@CleverFool77 CleverFool77 commented May 20, 2019 •
edited
Loading

Fixes #5708 part

Screenshot from 2019-06-05 20-29-10

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@CleverFool77
Copy link
Member Author

Hi @jywarren @gauravano @gautamig54
I just started off with search page result UI.
Thanks !!!

@CleverFool77 CleverFool77 added design issue requires more design work and discussion (i.e. mockups and sketches) outreachy summer-of-code review-me labels May 20, 2019
@plotsbot
Copy link
Collaborator

1 Message
📖 @CleverFool77 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@CleverFool77 CleverFool77 changed the title column tab in search results page [WIP] Column tab in search results page May 21, 2019
@CleverFool77 CleverFool77 mentioned this pull request May 27, 2019
Closed
@CleverFool77 CleverFool77 changed the title [WIP] Column tab in search results page Column tab in search results page Jun 5, 2019
@CleverFool77
Copy link
Member Author

Hi @jywarren Just pushed the latest changes to PR.
Thanks !!

@CleverFool77 CleverFool77 mentioned this pull request Jun 5, 2019
Closed
20 tasks
@CleverFool77
Copy link
Member Author

I'll be closing this Issue as I'll soon make a new PR with new design changes.

UI improvements - Summer Of Code 2019 automation moved this from In progress to Done Jun 5, 2019
@CleverFool77 CleverFool77 moved this from Done to Closed Without Merge in UI improvements - Summer Of Code 2019 Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren Awaiting requested review from jywarren

Assignees
No one assigned
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) outreachy summer-of-code
Projects
No open projects
UI improvements - Summer Of Code 2019
  
Closed Without Merge ( Not Done)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI improvements Planning Issue : Searchbar and Search Results page
2 participants
@CleverFool77 @plotsbot