-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] SearchResults: Add custom google search results #5978
Conversation
Hi @jywarren For this addition, I read this answer in my search
So I went and researched. I saw that If we want the results to be displaced like google, then searchbox is must !!!!
We can do make this json response to look like google result. But for that we have to add lot new more lines of code too. It would lots of styling and many other stuff to make the data look like google result. |
Hi! So, for this, we can just do exactly what we're doing on https://publiclab.org/w/search -- See the code here: https://publiclab.org/notes/raw/19093 No need at this point to try to hide the input or anything. I think it works for now! Once this is in place, we can work some follow-ups! |
Hmm, wonder why this didn't generate screenshots? But, in changing the search page we may have to change the tests that confirm its interface. |
Yes, but to also intercept the search term "test" and display results for
it instead of our internal search system's results. Then internal search
results would show only under "by type". What do you think?
…On Sat, Jul 6, 2019, 7:00 AM Lekhika Dugtal ***@***.***> wrote:
So what you mean is to do this ?
ss attached 👍
[image: Screenshot from 2019-07-06 16-29-15]
<https://user-images.githubusercontent.com/26685258/60755291-3e311800-a00b-11e9-88cf-b07077d596f6.png>
I just addded the lines you provided in the code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5978?email_source=notifications&email_token=AAAF6J4MRZIG5RM7NOENDY3P6B3L3A5CNFSM4H6HNM42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKXJTA#issuecomment-508916940>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J2LVYRTOXZVUSMATWTP6B3L3ANCNFSM4H6HNM4Q>
.
|
So you mean when I search test on searchbox for custom google like this ? or did you mean that as soon as we got /search/test url after typing some |
I believe the code from the wiki page I shared intercepts any ?q=Searchterm
parameter, so if we make the navbar "view all" link go to
/search?q=searchterm then we can intercept it and show the results!
…On Sat, Jul 6, 2019, 7:32 AM Lekhika Dugtal ***@***.***> wrote:
So you mean when I search test on searchbox for custom google like this ?
[image: gg]
<https://user-images.githubusercontent.com/26685258/60755603-b7326e80-a00f-11e9-829b-0b7a9b149917.gif>
or did you mean that as soon as we got /search/test url after typing some
test on searchbar of navbar , then we should get google results first ?
and internal results should be given only when we press by type. But As I
said above, Isn't it necessary to use google's searchbox to show the google
results.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5978?email_source=notifications&email_token=AAAF6JY2LWBVCIFGJ3HH6TDP6B7DJA5CNFSM4H6HNM42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKXYKI#issuecomment-508918825>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J7Q7FN2JNBMNSVQTHTP6B7DJANCNFSM4H6HNM4Q>
.
|
Damn !!!! I finallyy get itttttttttttttttttttt !! 🎉 |
I'm so sorry I was being so hard to understand!!! |
Nooo !! It was me who wasn't able to understand !!! |
Hi, just checking in on this! How is it going? Thanks! |
Hi Jeff !!
I'll update this soon.
…On Wed, Jul 24, 2019 at 11:44 PM Jeffrey Warren ***@***.***> wrote:
Hi, just checking in on this! How is it going? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5978?email_source=notifications&email_token=AGLS6SS2PW2YEROSFP34Z6TQBCL2FA5CNFSM4H6HNM42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2XFN2A#issuecomment-514741992>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGLS6SXWPNKVPE6TCVBYKFTQBCL2FANCNFSM4H6HNM4Q>
.
|
I'm catching up today but if this got finished can you link to the final pr? Thank you!!! |
Hi @jywarre I'm unable to make the google custom searchbar as the searchbar
we need in Navbar of PublicLab.
because what we need it is google result first, so it should be custum
search bar rather than what we are using now. But I'm unable to change it
according to our need in this navbar.
Thus it is creating problems.
So I was checking some blogs and exploring. But what they are using is
directly the custom searchbar and they need not do the changes but here, we
are supposed to use them.
…On Fri, Aug 2, 2019 at 1:52 PM Jeffrey Warren ***@***.***> wrote:
I'm catching up today but if this got finished can you link to the final
pr? Thank you!!!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#5978?email_source=notifications&email_token=AGLS6SX5MR5AWP3GSB52EETQCPVEJA5CNFSM4H6HNM42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NBGZI#issuecomment-517608293>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGLS6SWSKEPR36KZY4KZ5RTQCPVEJANCNFSM4H6HNM4Q>
.
|
I was thinking that that I'll try for this again after Finishing the design
parts.
…On Fri, Aug 2, 2019 at 2:03 PM lekhi dugtal ***@***.***> wrote:
Hi @jywarre I'm unable to make the google custom searchbar as the
searchbar we need in Navbar of PublicLab.
because what we need it is google result first, so it should be custum
search bar rather than what we are using now. But I'm unable to change it
according to our need in this navbar.
Thus it is creating problems.
So I was checking some blogs and exploring. But what they are using is
directly the custom searchbar and they need not do the changes but here, we
are supposed to use them.
On Fri, Aug 2, 2019 at 1:52 PM Jeffrey Warren ***@***.***>
wrote:
> I'm catching up today but if this got finished can you link to the final
> pr? Thank you!!!
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#5978?email_source=notifications&email_token=AGLS6SX5MR5AWP3GSB52EETQCPVEJA5CNFSM4H6HNM42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NBGZI#issuecomment-517608293>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AGLS6SWSKEPR36KZY4KZ5RTQCPVEJANCNFSM4H6HNM4Q>
> .
>
|
No description provided.