Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump reverse_markdown from 1.1.0 to 1.3.0 #6261

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Sep 9, 2019

Bumps reverse_markdown from 1.1.0 to 1.3.0.

Changelog

Sourced from reverse_markdown's changelog.

1.3.0 - September 2019

  • Add support for s HTML tag, thanks @​fauno

1.2.0 - August 2019

  • Handle windows \r\n within text blocks, thanks for reporting @​krisdigital
  • Handle paragraphs in li tags, thanks @​gstamp
Commits
  • d18fd18 Add s tag for strikethrough
  • 1b4b81c Add spec for indentation
  • e773c45 Bump jruby to see if it helps
  • 0df663f Merge pull request #75 from envato/fix_spaces_between_list_items
  • 950e7d5 Update syntax for older ruby versions.
  • f33e462 Deal with lists that have extra lines between them.
  • dab31f0 Merge pull request #74 from michaelglass/patch-1
  • a0853cd add license to gemspec
  • 4a893bc Update travis
  • 4c1b8f5 Handle windows style \r\n correctly, see #64
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file Ruby labels Sep 9, 2019
@jywarren
Copy link
Member

Wow! Interesting!

This change broke our tests:

Handle windows \r\n within text blocks, thanks for reporting @​krisdigital

We need to add \r to a couple test responses for this to work. Cool!

 test_should_parse_incoming_mail_from_outlook_service_correctly_and_add_comment_reply#OutlookParsingTest (11.40s)
        --- expected
        +++ actual
        @@ -1,4 +1,4 @@
        -" This is the second reply sent by the user.
        +"\r This is the second reply sent by the user.
         <!-- @@$$%% Trimmed Content @@$$%% -->* * *
         
         <font face=\"Calibri, sans-serif\" style=\"font-size:11pt\" color=\"#000000\"><b>From:</b> TestUser PublicLab<br>\r
        @@ -15,7 +15,7 @@
         -->\r
         </style>
         
        - This is the first reply sent by the user.
        +\r This is the first reply sent by the user.
         
         * * *
         
        test/integration/incoming_mail_parsing_test/outlook_parsing_test.rb:13:in `block in <class:OutlookParsingTest>'

@cesswairimu
Copy link
Collaborator

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@cesswairimu
Copy link
Collaborator

@dependabot recreate

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/reverse_markdown-1.3.0 branch from c087832 to ef9effd Compare December 23, 2019 19:11
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/reverse_markdown-1.3.0 branch 2 times, most recently from 065917d to 2dcce27 Compare January 3, 2020 17:21
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #6261 into master will decrease coverage by 27.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6261       +/-   ##
===========================================
- Coverage   80.83%   53.22%   -27.62%     
===========================================
  Files          97       97               
  Lines        5574     5683      +109     
===========================================
- Hits         4506     3025     -1481     
- Misses       1068     2658     +1590
Impacted Files Coverage Δ
app/models/drupal_content_field_mapper.rb 0% <0%> (-100%) ⬇️
app/mailers/node_mailer.rb 0% <0%> (-100%) ⬇️
app/mailers/password_reset_mailer.rb 0% <0%> (-100%) ⬇️
app/models/drupal_content_field_map_editor.rb 0% <0%> (-100%) ⬇️
app/controllers/features_controller.rb 0% <0%> (-80.71%) ⬇️
app/controllers/like_controller.rb 0% <0%> (-72.23%) ⬇️
app/controllers/relationships_controller.rb 0% <0%> (-71.43%) ⬇️
app/controllers/images_controller.rb 0% <0%> (-70.28%) ⬇️
app/services/search_service.rb 27.18% <0%> (-67.97%) ⬇️
app/mailers/admin_mailer.rb 37.5% <0%> (-62.5%) ⬇️
... and 39 more

Bumps [reverse_markdown](https://github.com/xijo/reverse_markdown) from 1.1.0 to 1.3.0.
- [Release notes](https://github.com/xijo/reverse_markdown/releases)
- [Changelog](https://github.com/xijo/reverse_markdown/blob/master/CHANGELOG.md)
- [Commits](xijo/reverse_markdown@v1.1.0...v1.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/reverse_markdown-1.3.0 branch from 2dcce27 to 53ac213 Compare January 7, 2020 14:33
@plotsbot
Copy link
Collaborator

plotsbot commented Jan 7, 2020

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @dependabot-preview[bot] Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

6261-test_questions.png

6261-test_embeddable_grids.png

6261-test_signup.png

6261-test_viewing_the_settings_page.png

6261-test_tag_by_author_page.png

6261-test_wiki_page_with_inline_grids.png

6261-test_stats.png

6261-test_viewing_the_dashboard.png

6261-test_searching_an_item_from_the_homepage.png

6261-test_signup_modal_form_validation.png

6261-test_questions_shadow.png

6261-test_login_modal.png

6261-test_profile_page.png

6261-test_comments.png

6261-test_tags.png

6261-test_signup_modal.png

6261-test_wiki.png

6261-test_methods.png

6261-test_tag_page.png

6261-test_blog_page_with_location_modal.png

6261-test_tag_wildcard.png

6261-test_signup_modal_disabled_submit_button_on_empty_username.png

6261-test_embeddable_thumbnail_grids.png

6261-test_front_page_with_navbar_search_autocomplete.png

6261-test_login.png

6261-test_viewing_the_dropdown_menu.png

6261-test_viewing_question_post.png

6261-test_mobile_displays.png

6261-test_simple-data-grapher_powertag.png

6261-test_front.png

6261-test_question_page.png

6261-test_tag_contributors_page.png

6261-test_blog.png

6261-test_people.png

6261-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@dependabot-preview
Copy link
Contributor Author

Superseded by #7139.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/reverse_markdown-1.3.0 branch January 7, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants