-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add welcome message to features #7286
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7286 +/- ##
==========================================
+ Coverage 81.59% 81.86% +0.26%
==========================================
Files 97 97
Lines 5602 5602
==========================================
+ Hits 4571 4586 +15
+ Misses 1031 1016 -15
|
22d9d2d
to
f9e841d
Compare
@jywarren not sure if these are all the changes required 😅 ..can you help review this and point in the right direction? Thanks 😄 |
app/views/comments/_form.html.erb
Outdated
@@ -39,6 +39,9 @@ | |||
%> | |||
<% if is_new_contributor %> | |||
<div id="new_contributor_msg"> | |||
<% cache('feature_welcome-msg', skip_digest: true) do %> | |||
<%= feature("welcome-msg") %> | |||
<% end %> | |||
<p><i class="fa fa-hand-peace-o" aria-hidden="true"></i> | |||
<%= author %> is a new contributor. Take care in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, actually we can remove the message you've added, and I can add it directly to the database so that it becomes the current feature text. Then we can merge your code and next time it's published, it'll pick up the text!
f9e841d
to
14e38ca
Compare
@jywarren is this alright? |
@jywarren the travis failure seems to be unrelated to my changes can you kindly check? |
Restarting travis |
@jywarren not sure why the tests are failing can you help me out?Thanks ✌️ Not really sure if this is how the feature is to be implemented 😅 |
Huh. Very odd! I can't seem to get it to pass - you're totally right it's unrelated. Let me try again... sorry!!! |
@jywarren Ohh 😅 no issues 😄 any workaround for this ? |
|
Screenshots 📸 (click to expand)7286-test_questions.png7286-test_embeddable_grids.png7286-test_signup.png7286-test_viewing_the_settings_page.png7286-test_tag_by_author_page.png7286-test_wiki_page_with_inline_grids.png7286-test_stats.png7286-test_viewing_the_dashboard.png7286-test_searching_an_item_from_the_homepage.png7286-test_signup_modal_form_validation.png7286-test_tag_stats.png7286-test_login_modal_form_validation.png7286-test_questions_shadow.png7286-test_login_modal.png7286-test_profile_page.png7286-test_comments.png7286-test_tags.png7286-test_signup_modal.png7286-test_wiki.png7286-test_methods.png7286-test_tag_page.png7286-test_blog_page_with_location_modal.png7286-test_tag_wildcard.png7286-test_signup_modal_disabled_submit_button_on_empty_username.png7286-test_embeddable_thumbnail_grids.png7286-test_front_page_with_navbar_search_autocomplete.png7286-test_spam_moderation_page.png7286-test_login.png7286-test_viewing_the_dropdown_menu.png7286-test_viewing_question_post.png7286-test_mobile_displays.png7286-test_simple-data-grapher_powertag.png7286-test_front.png7286-test_question_page.png7286-test_tag_contributors_page.png7286-test_blog.png7286-test_people.png7286-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
Hooray!!! It worked! Sorry this was so bad! 🎉 ❤️ 💥 |
Thanks for your patience!!! |
Fixes #7277
rake test
@publiclab/reviewers
for help, in a comment below