Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled the dropdown button for a better margin #7368 #7380

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

theOpetunde
Copy link
Contributor

Added margin-right of 5px to the dropdown div class for better styling

Fixes #7368 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Added margin-right of 5px to the dropdown div class for better styling
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #7380 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7380   +/-   ##
=======================================
  Coverage   81.86%   81.86%           
=======================================
  Files          97       97           
  Lines        5602     5602           
=======================================
  Hits         4586     4586           
  Misses       1016     1016

Copy link
Contributor

@sssash18 sssash18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include screenshot of the changes?

@theOpetunde
Copy link
Contributor Author

code

Screenshot of changes made

@sssash18
Copy link
Contributor

code

Screenshot of changes made

@theOpetunde I meant screenshot of the ui changes.

Copy link
Member

@Uzay-G Uzay-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good!

@SidharthBansal
Copy link
Member

Please provide screenshots

@cesswairimu
Copy link
Collaborator

Screenshot
Screenshot from 2020-02-09 13-36-09

@cesswairimu cesswairimu merged commit 513c735 into publiclab:master Feb 9, 2020
@welcome
Copy link

welcome bot commented Feb 9, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@cesswairimu
Copy link
Collaborator

cesswairimu commented Feb 9, 2020

Thanks everyone and welocme to PublicLab @theOpetunde 🎈

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including a margin in by type button
5 participants