Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useremail.html.erb #7517

Closed
wants to merge 1 commit into from

Conversation

pierrecazaubon
Copy link

@pierrecazaubon pierrecazaubon commented Feb 16, 2020

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Feb 16, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@sssash18
Copy link
Contributor

@pierrecazaubon Please mention the issue number.

@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8d2efcb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7517   +/-   ##
=========================================
  Coverage          ?   81.75%           
=========================================
  Files             ?       97           
  Lines             ?     5612           
  Branches          ?        0           
=========================================
  Hits              ?     4588           
  Misses            ?     1024           
  Partials          ?        0

@cesswairimu
Copy link
Collaborator

thanks so much for opening this 🎉 could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks

@jywarren jywarren changed the base branch from master to main June 30, 2020 18:06
@cesswairimu
Copy link
Collaborator

Closing this because no link to the issue and the contributor has not communicated for more than a month hence difficult to review. Thanks for opening this and feel free to reopen and add the link to the issue you are solving. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants