-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7834: Update the file app/controllers/stats_controller.rb #7836
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## master #7836 +/- ##
=======================================
Coverage 81.97% 81.97%
=======================================
Files 97 97
Lines 5630 5630
=======================================
Hits 4615 4615
Misses 1015 1015
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongskyler LGTM! @cesswairimu @jywarren can you kindly check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Congrats on merging your first pull request! 馃檶馃帀鈿★笍 Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thanks @dongskyler 馃帀 for solving this and welcome to PublicLab. @Tlazypanda thanks a lot for the help 馃憤 |
@dongskyler .. sorry a little tweak in the method...could you change it as is on #7831 (comment) ? on a new PR and ping me to merge it? Thanks |
Yes @cesswairimu |
yes please...thanks |
I just submitted a PR #7851. The tests have been completed and passed. @cesswairimu |
Fixes #7834, originally titled "Filter spam tags from /stats/subscriptions #7834", although the task is to: Update the file app/controllers/stats_controller.rb in the plots2 repository.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!