Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7834: Update the file app/controllers/stats_controller.rb #7836

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fixes #7834: Update the file app/controllers/stats_controller.rb #7836

merged 1 commit into from
Apr 29, 2020

Conversation

dongskyler
Copy link
Member

@dongskyler dongskyler commented Apr 22, 2020

Fixes #7834, originally titled "Filter spam tags from /stats/subscriptions #7834", although the task is to: Update the file app/controllers/stats_controller.rb in the plots2 repository.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Apr 22, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 馃捒
There may be some errors, but don't worry! We'll work through them with you! 馃憤馃帀馃槃
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #7836 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7836   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          97       97           
  Lines        5630     5630           
=======================================
  Hits         4615     4615           
  Misses       1015     1015           
Impacted Files Coverage 螖
app/controllers/stats_controller.rb 74.19% <100.00%> (酶)

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongskyler LGTM! @cesswairimu @jywarren can you kindly check?

Copy link
Member

@govindgoel govindgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cesswairimu cesswairimu merged commit 16a0663 into publiclab:master Apr 29, 2020
@welcome
Copy link

welcome bot commented Apr 29, 2020

Congrats on merging your first pull request! 馃檶馃帀鈿★笍
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 馃槂. Please find the link pinned in the issue section 馃摑
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 馃檶

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 馃槙

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 馃槃 馃帀

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@cesswairimu
Copy link
Collaborator

Thanks @dongskyler 馃帀 for solving this and welcome to PublicLab. @Tlazypanda thanks a lot for the help 馃憤

@cesswairimu
Copy link
Collaborator

@dongskyler .. sorry a little tweak in the method...could you change it as is on #7831 (comment) ? on a new PR and ping me to merge it? Thanks

@dongskyler
Copy link
Member Author

dongskyler commented Apr 29, 2020

Yes @cesswairimu
Do you want me to create a new PR with the current code that closes #7831?

@cesswairimu
Copy link
Collaborator

yes please...thanks

@dongskyler
Copy link
Member Author

dongskyler commented Apr 29, 2020

yes please...thanks

I just submitted a PR #7851. The tests have been completed and passed. @cesswairimu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter spam tags from /stats/subscriptions
4 participants