Filter spam tags from /stats/subscriptions

[jywarren]

@ebarry reports:

Not urgent, but there are many spammy tags that have already been deleted from publiclab.org pages that are still showing up in the "0-9" subscriptions area of this page: https://publiclab.org/stats/subscriptions

We can edit the stats controller so that only tags that have at least one published node attached are displayed.

More in a moment (github outage!)

Here is the controller where we collect the tags:

plots2/app/controllers/stats_controller.rb

Lines 2 to 9 in 4f68d27

	def subscriptions
	@tags = {}
	TagSelection.where(following: true).each do |tag|
	@tags[tag.tagname] = @tags[tag.tagname] || 0
	@tags[tag.tagname] += 1
	end
	@tags = @tags.group_by { |_k, v| v / 10 }
	end

I think we can just add .joins(:node) ? If so this could be a FTO...!

plots2/app/models/tag.rb

Line 398 in 4f68d27

Tag.joins(:node)

It may need to be .joins(:tag, :node) ? This can be tested on the rails console.

[jywarren]

OK, confirmed that just .joins(:node_tags) works! Let's make this an FTO!

---

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

[jywarren]

Just to clarify, this would become:

TagSelection.where(following: true)
            .joins(:node_tags)
            .each do |tag| 

starting on line 4 of the code referenced above!