Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Uglifier gem to minify js #7937

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

Tlazypanda
Copy link
Collaborator

@Tlazypanda Tlazypanda commented May 20, 2020

Fixes #7887
Uglifier gem is configured to minify javascript files.

Tested in development by setting the asset compilation as true(setting the config.assets.debug to false and config.assets.compile to true in development.rb) and checking the asset files.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #7937 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7937      +/-   ##
==========================================
+ Coverage   82.04%   82.16%   +0.12%     
==========================================
  Files          97       97              
  Lines        5642     5642              
==========================================
+ Hits         4629     4636       +7     
+ Misses       1013     1006       -7     
Impacted Files Coverage Δ
app/controllers/stats_controller.rb 73.33% <100.00%> (ø)
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@cesswairimu
Copy link
Collaborator

travis has been running forever on this 🤔 @Tlazypanda try closing the PR and reopening

@Tlazypanda Tlazypanda closed this May 22, 2020
@Tlazypanda Tlazypanda reopened this May 22, 2020
@Tlazypanda
Copy link
Collaborator Author

@cesswairimu Travis passed yay!! 😄

@Tlazypanda
Copy link
Collaborator Author

Tlazypanda commented May 26, 2020

@jywarren @cesswairimu @emilyashley @SidharthBansal @VladimirMikulic can you kindly review? Thanks ✌️

Copy link
Member

@Uzay-G Uzay-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, the harmony mode will allow us to use ES6 so that is nice.

@Tlazypanda
Copy link
Collaborator Author

@Uzay-G Thanks a lot for the review 😄

@jywarren
Copy link
Member

jywarren commented Jun 3, 2020

Love this! Merging!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minify JS using Uglifier for performance
4 participants