spam2 stable issues, UI update and modals added #8034

keshavsethi · 2020-06-14T09:41:35Z

There were few bugs in the UI of the spam management dashboard.

Wrong ids in /comments and /revisions
created modal for comment and revisions
default order nodes wrt time
UI is updated as there were few issues related to banner in stable. Apart from that this new UI requires very less external css and it is based on bootstrap mostly. it has everything which was in old UI. This is fully responsive and better than the previous UI. I have attached some screenshots and gifs.

There are a few issues that I am facing currently:

/spam2 and /spam2/revision are giving error in stable while wiki and comment are fine, I think it might be due to invalid ID or something. I have changed it but not sure if it is the only issue.
I have added (&.) instead of (.) it will discard all values where node.author is nill. Please review this.
<a href="/profile/<%= node.author&.name %>"><%= node.author&.name %> <%= node.author&.new_contributor%></a>
Please review @jywarren @SidharthBansal @cesswairimu @pydevsg @ananyaarun @VladimirMikulic @Uzay-G @emilyashley
Thanks!!

codecov · 2020-06-14T09:44:46Z

Codecov Report

Merging #8034 into master will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8034      +/-   ##
==========================================
- Coverage   82.62%   82.41%   -0.21%     
==========================================
  Files          99       99              
  Lines        5737     5737              
==========================================
- Hits         4740     4728      -12     
- Misses        997     1009      +12

Impacted Files	Coverage Δ
app/controllers/spam2_controller.rb	`100.00% <100.00%> (ø)`
app/services/execute_search.rb	`88.88% <0.00%> (-5.56%)`	⬇️
app/api/srch/search.rb	`66.24% <0.00%> (-3.83%)`	⬇️
app/controllers/admin_controller.rb	`79.74% <0.00%> (-2.11%)`	⬇️

VladimirMikulic · 2020-06-14T10:05:03Z

Fix CI :)

jywarren · 2020-06-16T19:26:20Z

This is a follow-up to #7961 -- right? Would you mind linking together the issues in a central place so we can see them all in relation? Thank you!

sentry-io · 2020-06-16T19:27:10Z

Sentry issue: PLOTS2-RH

jywarren · 2020-06-16T19:28:00Z

Hi @keshavsethi -- here, can you see this? https://sentry.io/share/issue/0d9664f6f2db4194978b7671837928ee/

Also were you able to log into Sentry and do searches and link like I've done in the previous comment? Thanks!

jywarren · 2020-06-16T19:29:10Z

Hmm, regarding anniversary banner, is there a way to not use absolute positioning but to have it push down below if the banner exists? Otherwise, yes, we could exempt it. Thank you!!!

jywarren · 2020-06-16T19:29:42Z

and finally, sorry, would you be able to add a little more descriptive title here? it really helps when trying to link issues together with # autocompletion. Thank you!!!!!

keshavsethi · 2020-06-16T19:56:12Z

This is a follow-up to #7961 -- right? Would you mind linking together the issues in a central place so we can see them all in relation? Thank you!

#7961(closed)was the first draft then I /spam2 was changed a lot. This PR is just a few updates to that including errors in the stable. Thanks!

keshavsethi · 2020-06-16T19:58:47Z

Hi @keshavsethi -- here, can you see this? https://sentry.io/share/issue/0d9664f6f2db4194978b7671837928ee/

Also were you able to log into Sentry and do searches and link like I've done in the previous comment? Thanks!

@jywarren Yes, I saw error before in sentry. It was due to data: { confirm: 'Are you sure you want to delete "'+node.path+'"?' } I have changed node.path here in this PR to #{node.path}. I hope it should work now. Thanks!

keshavsethi · 2020-06-16T20:01:25Z

Hmm, regarding anniversary banner, is there a way to not use absolute positioning but to have it push down below if the banner exists? Otherwise, yes, we could exempt it. Thank you!!!

@jywarren I have changed UI a bit, This will work fine in stable.

Thanks!

app/controllers/spam2_controller.rb

keshavsethi · 2020-06-18T05:24:32Z

@jywarren @SidharthBansal @cesswairimu @pydevsg @ananyaarun @VladimirMikulic @Uzay-G @emilyashley I have changed UI a bit. Please review.
Thanks!!

pydevsg

Good work man @keshavsethi 🎉

pydevsg · 2020-06-18T07:23:55Z

app/assets/stylesheets/spam2.css

@@ -36,10 +36,6 @@
 	cursor: pointer;
 }

-.alert {


hey @keshavsethi , inplace of alert what else have you added .
Also can you tell me if you have added something in CSS when a model pop ups, thanks.

Alert is there, it is just a z-index for that which I have added when there was another top nav for bulk moderation(previous UI). Now I have moved that nav below the card and there is no need to specify z-index for alert. I have used a modal bootstrap class here.

keshavsethi · 2020-06-18T13:58:31Z

I have added a specific column search in moderation nav.it will help moderators to filter node to a greater extent. Refer to following screenshot

jywarren · 2020-06-23T16:00:59Z

Hi, this is super awesome. I have a few suggestions before we merge -- some easy, some maybe for a follow-up?

(A) - Could we have a “?” button too leading to /wiki/moderation#Dashboard where we add some documentation of each button?
(B and C) - could we group these together better? I don't know if Bootstrap has a style for this, but adding "Filter by author" instead of just "Author" could help clarify, and grouping them together could help people understand that the input text field is the term that is being used for the filtering. Also, if it has a placeholder text (via Bootstrap styles), it could say "Filter text" or something?
(D) perhaps after it says "filter" we should have a (clear) link that allows us to clear filters from that spot.

Thanks, what do you think? 🎉

ebarry · 2020-06-23T16:30:09Z

Thanks @keshavsethi, this dashboard is looking good!
👍 to @jywarren's 3 points.
I"m also wondering if there could be text "Select content below to take any of the following actions" above the buttons, and if the buttons could be shown in paler colors until there is content selected?

keshavsethi · 2020-06-23T19:35:42Z

Hi, this is super awesome. I have a few suggestions before we merge -- some easy, some may be for a follow-up?

(A) - Could we have a “?” button too leading to /wiki/moderation#Dashboard where we add some documentation of each button?

(B and C) - could we group these together better? I don't know if Bootstrap has a style for this, but adding "Filter by author" instead of just "Author" could help clarify, and grouping them together could help people understand that the input text field is the term that is being used for the filtering. Also, if it has a placeholder text (via Bootstrap styles), it could say "Filter text" or something?

(D) perhaps after it says "filter" we should have a (clear) link that allows us to clear filters from that spot.

Thanks, what do you think?

Hey @jywarren, I have added an info button, I will link it with wiki page once it is made. I have made B and C as a part of a single button group and added a tooltip for it for reference. There is a reset button in the header of the table which becomes red if we apply any filter and black if no filter is applied I have also disabled bulk moderation buttons if nothing is selected. and I have updated UI a bit. please refer to the following Screenshot.

@jywarren Please review these changes, Thanks!!

keshavsethi · 2020-06-23T19:37:35Z

Thanks @keshavsethi, this dashboard is looking good!
to @jywarren's 3 points.
I"m also wondering if there could be text "Select content below to take any of the following actions" above the buttons, and if the buttons could be shown in paler colors until there is content selected?

@ebarry, I have disabled the buttons if nothing is selected, Thanks!!

jywarren · 2020-06-23T19:38:27Z

Oh WOW. @keshavsethi this is very fast work! I'll merge it now!

jywarren · 2020-06-23T19:39:39Z

It'll be testable at https://stable.publiclab.org/spam2 soon. And if that works, i may try to push it into production today! We'll keep an eye out!!!

jywarren · 2020-06-23T19:40:10Z

Congrats!! 🎉

keshavsethi · 2020-06-23T19:40:42Z

It'll be testable at https://stable.publiclab.org/spam2 soon. And if that works, i may try to push it into production today! We'll keep an eye out!!!

Sure, Thanks!! 😄

cesswairimu · 2020-06-24T17:49:21Z

🎉 🎉

keshavsethi added 2 commits June 14, 2020 13:59

ui-update

6ccca9b

if-cache

ba02d53

keshavsethi requested review from VladimirMikulic, Uzay-G, ananyaarun, cesswairimu, jywarren, pydevsg and SidharthBansal June 14, 2020 09:42

keshavsethi added 6 commits June 14, 2020 21:10

travis

a6cbc8d

before action spam2

9f55771

system test issue

6c3abab

delete node test

fc83129

string issue

4a70e9c

node path issue

9faf5b7

This was referenced Jun 16, 2020

system tests for spam2 #8038

Merged

Weekly Community Check-In #63 - Stay Updated! #8040

Closed

jywarren added this to the Spam! milestone Jun 16, 2020

jywarren mentioned this pull request Jun 16, 2020

stable revision issue #8037

Closed

margin added if cached

a6fecc8

cesswairimu reviewed Jun 17, 2020

View reviewed changes

app/controllers/spam2_controller.rb Show resolved Hide resolved

keshavsethi added 2 commits June 18, 2020 09:03

spam 2 ui update

2213822

ui spam2 issues

f92dd09

keshavsethi changed the title ~~spam2 stable issues and modals added~~ spam2 stable issues, UI update and modals added Jun 18, 2020

keshavsethi requested a review from cesswairimu June 18, 2020 05:31

pydevsg reviewed Jun 18, 2020

View reviewed changes

keshavsethi added 2 commits June 18, 2020 19:12

specific coloumn search

53d16b5

formatting

ee2a1e9

keshavsethi added 2 commits June 20, 2020 15:03

menu btn changed

1861c0a

tests and alerts in spam2

f6c3b95

keshavsethi mentioned this pull request Jun 20, 2020

tag page tab overhaul, removing sidebar, styling/spacing tweaks #8046

Merged

stable error

dc77f27

keshavsethi requested a review from pydevsg June 20, 2020 12:34

spam2 ui update

62dbc00

jywarren approved these changes Jun 23, 2020

View reviewed changes

jywarren merged commit 9559d6e into publiclab:master Jun 23, 2020

jywarren mentioned this pull request Jun 23, 2020

Weekly Community Check-In #64 - We are here for you. #8059

Closed

This was referenced Jun 29, 2020

GSoC'20: "Spam Management Dashboard" Project Planning #7885

Closed

Weekly Community Check-In #65 - GSoC First Eval Due this week publiclab/spectral-workbench#520

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

spam2 stable issues, UI update and modals added #8034

spam2 stable issues, UI update and modals added #8034

keshavsethi commented Jun 14, 2020 •

edited

Loading

codecov bot commented Jun 14, 2020 •

edited

Loading

VladimirMikulic commented Jun 14, 2020

jywarren commented Jun 16, 2020

sentry-io bot commented Jun 16, 2020

jywarren commented Jun 16, 2020

jywarren commented Jun 16, 2020

jywarren commented Jun 16, 2020

keshavsethi commented Jun 16, 2020

keshavsethi commented Jun 16, 2020

keshavsethi commented Jun 16, 2020 •

edited

Loading

keshavsethi commented Jun 18, 2020

pydevsg left a comment

pydevsg Jun 18, 2020 •

edited by keshavsethi

Loading

keshavsethi Jun 18, 2020

pydevsg Jun 21, 2020

keshavsethi commented Jun 18, 2020

jywarren commented Jun 23, 2020

ebarry commented Jun 23, 2020

keshavsethi commented Jun 23, 2020

keshavsethi commented Jun 23, 2020

jywarren commented Jun 23, 2020

jywarren commented Jun 23, 2020

jywarren commented Jun 23, 2020

keshavsethi commented Jun 23, 2020

cesswairimu commented Jun 24, 2020

spam2 stable issues, UI update and modals added #8034

spam2 stable issues, UI update and modals added #8034

Conversation

keshavsethi commented Jun 14, 2020 • edited Loading

codecov bot commented Jun 14, 2020 • edited Loading

Codecov Report

VladimirMikulic commented Jun 14, 2020

jywarren commented Jun 16, 2020

sentry-io bot commented Jun 16, 2020

jywarren commented Jun 16, 2020

jywarren commented Jun 16, 2020

jywarren commented Jun 16, 2020

keshavsethi commented Jun 16, 2020

keshavsethi commented Jun 16, 2020

keshavsethi commented Jun 16, 2020 • edited Loading

keshavsethi commented Jun 18, 2020

pydevsg left a comment

Choose a reason for hiding this comment

pydevsg Jun 18, 2020 • edited by keshavsethi Loading

Choose a reason for hiding this comment

keshavsethi Jun 18, 2020

Choose a reason for hiding this comment

pydevsg Jun 21, 2020

Choose a reason for hiding this comment

keshavsethi commented Jun 18, 2020

jywarren commented Jun 23, 2020

ebarry commented Jun 23, 2020

keshavsethi commented Jun 23, 2020

keshavsethi commented Jun 23, 2020

jywarren commented Jun 23, 2020

jywarren commented Jun 23, 2020

jywarren commented Jun 23, 2020

keshavsethi commented Jun 23, 2020

cesswairimu commented Jun 24, 2020

keshavsethi commented Jun 14, 2020 •

edited

Loading

codecov bot commented Jun 14, 2020 •

edited

Loading

keshavsethi commented Jun 16, 2020 •

edited

Loading

pydevsg Jun 18, 2020 •

edited by keshavsethi

Loading