Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests for spam2 #8038

Merged
merged 1 commit into from
Jun 16, 2020
Merged

system tests for spam2 #8038

merged 1 commit into from
Jun 16, 2020

Conversation

keshavsethi
Copy link
Member

System tests for Spam2

@jywarren @cesswairimu @VladimirMikulic @ebarry @emilyashley @pydevsg @ananyaarun @SidharthBansal @Uzay-G Please review and give suggestions

I am having a few issues related to stable spam2 which I have mentioned in #8034 Please review this as well

Thanks!

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #8038 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8038      +/-   ##
==========================================
+ Coverage   82.34%   82.62%   +0.27%     
==========================================
  Files          99       99              
  Lines        5737     5737              
==========================================
+ Hits         4724     4740      +16     
+ Misses       1013      997      -16     
Impacted Files Coverage Δ
app/controllers/admin_controller.rb 81.85% <0.00%> (+3.79%) ⬆️
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great. If this looks ready and can merge without other PRs going first, it looks great to me!!! Can you confirm this? Thanks!!!!

@keshavsethi
Copy link
Member Author

@jywarren Yes, we can merge this. Thanks!!

@jywarren jywarren merged commit 6c84170 into publiclab:master Jun 16, 2020
@jywarren
Copy link
Member

Awesome. Fantastic work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants