Fix tag_controller failing test #8228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #8228 +/- ##
==========================================
- Coverage 81.81% 81.69% -0.12%
==========================================
Files 100 100
Lines 5846 5846
==========================================
- Hits 4783 4776 -7
- Misses 1063 1070 +7
|
jywarren
reviewed
Aug 3, 2020
| <% end %> | ||
| </div> | ||
|
|
||
| </div></div> |
There was a problem hiding this comment.
Hmm, so were we missing these close div tags?
jywarren
approved these changes
Aug 3, 2020
| <a rel="tooltip" title="<%= translation('sidebar._post_button.share_your_work') %>" data-placement="bottom" href="/post?tags=<%= @title %>" class="btn btn-primary requireLogin">New post <i class="fa fa-plus fa-white"></i></a> | ||
| <% else %> | ||
| <a class="btn btn-primary requireLogin" target="_blank" href="/subscribe/tag/<%= params[:id] %>"> Follow</a> | ||
| <% if @related_tags %> |
There was a problem hiding this comment.
Oh no! This was my fault for sure. I accidentally committed this without final checks because I misunderstood the gitpod interface. I thought it was to push to a feature branch but it went to main! 😱
Thanks for catching and solving this!!!
cypherean
pushed a commit
to cypherean/plots2
that referenced
this pull request
Aug 5, 2020
* skip if no related tags * proper indentation
dms-yondy
pushed a commit
to dms-yondy/plots2
that referenced
this pull request
Aug 7, 2020
* skip if no related tags * proper indentation
nadimakhtar97
pushed a commit
to nadimakhtar97/plots2
that referenced
this pull request
Sep 21, 2020
* skip if no related tags * proper indentation
shubhangikori
pushed a commit
to shubhangikori/plots2
that referenced
this pull request
Oct 12, 2020
* skip if no related tags * proper indentation
alvesitalo
pushed a commit
to alvesitalo/plots2
that referenced
this pull request
Oct 14, 2020
* skip if no related tags * proper indentation
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
* skip if no related tags * proper indentation
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* skip if no related tags * proper indentation
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* skip if no related tags * proper indentation
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* skip if no related tags * proper indentation
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
* skip if no related tags * proper indentation
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* skip if no related tags * proper indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes current travis failures
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!