Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from http:// to https:// #8656

Closed
wants to merge 3 commits into from
Closed

Change from http:// to https:// #8656

wants to merge 3 commits into from

Conversation

Onyinye91-ctrl
Copy link
Contributor

@Onyinye91-ctrl Onyinye91-ctrl commented Oct 21, 2020

Fixes #8690

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Oct 21, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 21, 2020

@Onyinye91-ctrl
Copy link
Contributor Author

Onyinye91-ctrl commented Oct 21, 2020

Issue Solved plots2/app/models/drupal_content_type_map.rb (Fix for #6391) #8587

@codeclimate
Copy link

codeclimate bot commented Oct 21, 2020

Code Climate has analyzed commit 5a91a71 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #8656 into main will increase coverage by 0.01%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8656      +/-   ##
==========================================
+ Coverage   81.76%   81.77%   +0.01%     
==========================================
  Files         101      101              
  Lines        5901     5905       +4     
==========================================
+ Hits         4825     4829       +4     
  Misses       1076     1076              
Impacted Files Coverage Δ
app/controllers/stats_controller.rb 71.87% <0.00%> (ø)
app/controllers/application_controller.rb 92.24% <100.00%> (ø)
app/controllers/notes_controller.rb 83.53% <100.00%> (+0.06%) ⬆️
app/controllers/tag_controller.rb 81.45% <100.00%> (+0.05%) ⬆️
app/controllers/user_tags_controller.rb 84.28% <100.00%> (ø)
app/models/comment.rb 77.66% <100.00%> (+0.14%) ⬆️
app/models/drupal_content_type_map.rb 92.59% <100.00%> (ø)
app/models/node.rb 91.45% <100.00%> (ø)

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Onyinye91-ctrl some of these files have already been worked on by other contributors 😅 can you identify any other files where we can make this change and comment in the issue with the file that you will be working with?

@cesswairimu
Copy link
Collaborator

Hi, seems the issue you were fixed in this PR was closed..Closing this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename The Draft Method To Save_Draft For Clarity
3 participants