Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style.css #8695

Closed
wants to merge 1 commit into from
Closed

Conversation

amarachi-nwokocha
Copy link
Contributor

@amarachi-nwokocha amarachi-nwokocha commented Oct 29, 2020

i added styles on lines 46 to 49 to take care of the overflowing links
Fixes #0000 (<=== #6767)
my solution is https://github.com/publiclab/plots2/pull/8695/files

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

i added styles on lines 46 to 49  to take care of the overflowing links
@gitpod-io
Copy link

gitpod-io bot commented Oct 29, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 29, 2020

Code Climate has analyzed commit b61ace0 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #8695 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8695   +/-   ##
=======================================
  Coverage   81.77%   81.77%           
=======================================
  Files         101      101           
  Lines        5905     5905           
=======================================
  Hits         4829     4829           
  Misses       1076     1076           

@cypherean
Copy link
Contributor

Hey @amarachi-nwokocha!

A good practice is naming your PR with a brief description of the issue fixed and/or adding it in the PR name. For example, here it could've been Fixes overflow issues in small devices (#6767) . This is easier to trace back to and would be quick to review.

For any UI changes/fixes attach a screenshot of the change in the PR.

Good luck!

@sagarpreet-chadha
Copy link
Contributor

Hey @amarachi-nwokocha , can you add screenshots of before and after your solve 😄

@cesswairimu
Copy link
Collaborator

Hey @amarachi-nwokocha, I understand you might be held up..but if you ever get all the changes on one branch feel free to open a new PR. Closing this. Thanks

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants