changed deliver_now to deliver_later #9402

anirudhprabhakaran3 · 2021-03-31T02:38:12Z

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

…ler.rb

welcome · 2021-03-31T02:38:15Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

gitpod-io · 2021-03-31T02:38:15Z

codecov · 2021-03-31T02:45:42Z

Codecov Report

❗ No coverage uploaded for pull request base (main@04bb121). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5bd04c4 differs from pull request most recent head 8efca6f. Consider uploading reports for the commit 8efca6f to get more accurate results

@@           Coverage Diff           @@
##             main    #9402   +/-   ##
=======================================
  Coverage        ?   58.60%           
=======================================
  Files           ?       98           
  Lines           ?     5991           
  Branches        ?        0           
=======================================
  Hits            ?     3511           
  Misses          ?     2480           
  Partials        ?        0

anirudhprabhakaran3 · 2021-03-31T03:05:46Z

@jywarren could you tell me why the functional tests are failing? Is it due to the same reason mentioned by @cesswairimu at #9383?

cesswairimu · 2021-03-31T08:23:16Z

Hi @anirudhprabhakaran3 , yeah it is because of the same reason...would you like to make similar changes as I suggested on the other PR?

anirudhprabhakaran3 · 2021-03-31T08:26:17Z

Yes, I'll update the code based on the information you've given already! Thank you!

cesswairimu · 2021-03-31T08:28:53Z

Awesome 🎉
in your case it will be on these failing tests

===ERROR NotesControllerTest#test_co-author_can_publish_the_draft (73.31s)
Minitest::UnexpectedError:         NoMethodError: undefined method `subject' for nil:NilClass
            test/functional/notes_controller_test.rb:880:in `block in <class:NotesControllerTest>'

ERROR NotesControllerTest#test_draft_author_can_publish_the_draft (73.77s)
Minitest::UnexpectedError:         NoMethodError: undefined method `subject' for nil:NilClass
            test/functional/notes_controller_test.rb:860:in `block (2 levels) in <class:NotesControllerTest>'
            test/functional/notes_controller_test.rb:846:in `block in <class:NotesControllerTest>'

===ERROR NotesControllerTest#test_moderator_can_publish_the_draft (77.62s)
Minitest::UnexpectedError:         NoMethodError: undefined method `subject' for nil:NilClass
            test/functional/notes_controller_test.rb:835:in `block in <class:NotesControllerTest>'

cesswairimu · 2021-03-31T08:33:15Z

Just realized they are the same failing test as #9383 ..the details there should apply...thanks

anirudhprabhakaran3 · 2021-03-31T10:08:25Z

ALL CHECKS PASSED!

Sorry I'm really excited XD

cesswairimu · 2021-03-31T10:17:49Z

Fantastic 🎉 thanks a bunch

anirudhprabhakaran3 · 2021-03-31T10:40:32Z

Thank you! I have a few questions.

Is this going to be merged?
Can I start working on my GSoc proposal?

cesswairimu · 2021-03-31T12:55:28Z

@anirudhprabhakaran3 looks like you touched two files that were not part of your changes yarn.lock and package.json..could you please remove those?

And yeah it will be merged once you fix those
And yes, you can start working on your proposal. Thanks

anirudhprabhakaran3 · 2021-03-31T13:32:11Z

Aah yes. I think those two files were changed when I ran the webpacker and react install. I'll make the changes and push it 👍

anirudhprabhakaran3 · 2021-04-01T06:59:38Z

@cesswairimu made all changes and tests have passed

package.json

codeclimate · 2021-04-03T06:49:06Z

Code Climate has analyzed commit 8efca6f and detected 0 issues on this pull request.

View more on Code Climate.

anirudhprabhakaran3 · 2021-04-03T06:49:29Z

@RuthNjeri I've made the necessary changes. Now only two files have been edited

cesswairimu · 2021-04-03T20:26:32Z

Hi @anirudhprabhakaran3, looks like you made the changes for #9309 instead of #9308 as you linked in the issue...I understand the confusion because they had similar titles...I will update the issue number and merge the changes as you have worked a lot on it and the contributor on other PR hasn't gotten back to us in a while. Thanks

cesswairimu

🎉 🎉

welcome · 2021-04-03T20:29:11Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

* changed deliver_now to deliver_later in app/controllers/notes_controller.rb * Modified tests to reflect change * Reverse the unwanted changes * reverted unwanted changes

changed deliver_now to deliver_later in app/controllers/notes_control…

1b7f706

…ler.rb

Modified tests to reflect change

9a200b4

Reverse the unwanted changes

321a7e4

RuthNjeri reviewed Apr 1, 2021

View reviewed changes

package.json Outdated Show resolved Hide resolved

reverted unwanted changes

8efca6f

cesswairimu approved these changes Apr 3, 2021

View reviewed changes

cesswairimu merged commit f8a2a45 into publiclab:main Apr 3, 2021

cesswairimu mentioned this pull request Apr 3, 2021

Change deliver_now to deliver_later #9383

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

changed deliver_now to deliver_later #9402

changed deliver_now to deliver_later #9402

anirudhprabhakaran3 commented Mar 31, 2021 •

edited by cesswairimu

Loading

welcome bot commented Mar 31, 2021

gitpod-io bot commented Mar 31, 2021 •

edited

Loading

codecov bot commented Mar 31, 2021 •

edited

Loading

anirudhprabhakaran3 commented Mar 31, 2021

cesswairimu commented Mar 31, 2021

anirudhprabhakaran3 commented Mar 31, 2021

cesswairimu commented Mar 31, 2021 •

edited

Loading

cesswairimu commented Mar 31, 2021

anirudhprabhakaran3 commented Mar 31, 2021

cesswairimu commented Mar 31, 2021

anirudhprabhakaran3 commented Mar 31, 2021

cesswairimu commented Mar 31, 2021

anirudhprabhakaran3 commented Mar 31, 2021

anirudhprabhakaran3 commented Apr 1, 2021

codeclimate bot commented Apr 3, 2021

anirudhprabhakaran3 commented Apr 3, 2021

cesswairimu commented Apr 3, 2021 •

edited

Loading

cesswairimu left a comment

welcome bot commented Apr 3, 2021

changed deliver_now to deliver_later #9402

changed deliver_now to deliver_later #9402

Conversation

anirudhprabhakaran3 commented Mar 31, 2021 • edited by cesswairimu Loading

welcome bot commented Mar 31, 2021

gitpod-io bot commented Mar 31, 2021 • edited Loading

codecov bot commented Mar 31, 2021 • edited Loading

Codecov Report

anirudhprabhakaran3 commented Mar 31, 2021

cesswairimu commented Mar 31, 2021

anirudhprabhakaran3 commented Mar 31, 2021

cesswairimu commented Mar 31, 2021 • edited Loading

cesswairimu commented Mar 31, 2021

anirudhprabhakaran3 commented Mar 31, 2021

cesswairimu commented Mar 31, 2021

anirudhprabhakaran3 commented Mar 31, 2021

cesswairimu commented Mar 31, 2021

anirudhprabhakaran3 commented Mar 31, 2021

anirudhprabhakaran3 commented Apr 1, 2021

codeclimate bot commented Apr 3, 2021

anirudhprabhakaran3 commented Apr 3, 2021

cesswairimu commented Apr 3, 2021 • edited Loading

cesswairimu left a comment

Choose a reason for hiding this comment

welcome bot commented Apr 3, 2021

anirudhprabhakaran3 commented Mar 31, 2021 •

edited by cesswairimu

Loading

gitpod-io bot commented Mar 31, 2021 •

edited

Loading

codecov bot commented Mar 31, 2021 •

edited

Loading

cesswairimu commented Mar 31, 2021 •

edited

Loading

cesswairimu commented Apr 3, 2021 •

edited

Loading