Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies in expected values in tests compared to documentation #1733

Closed
drclaw1394 opened this issue Apr 7, 2023 · 1 comment
Closed
Assignees

Comments

@drclaw1394
Copy link

Hi there,

The first line of text on https://publicsuffix.org states:

A "public suffix" is one under which Internet users can (or historically could) directly register names. Some examples of public suffixes are .com, .co.uk and pvt.k12.ma.us. The Public Suffix List is a list of all known public suffixes.

.com is explicitly mentioned as a public suffix, yet the tests/tests.txt file has a few test of '.com' ( mixed case, with and without the leading dot), and the expected result are all 'null'. This seems to contradict the stated definition of a public suffix.

Also the the 'Algorithm/Definition' section in the wiki states:

A domain or rule can be split into a list of labels using the separator "." (dot). The separator is not part of any of the labels. Empty labels are not permitted, meaning that leading and trailing dots are ignored.

The leading dot should be ignored, however tests.txt file lists expected results of 'null' for all tests with a leading dot.

My apologies if this is documented somewhere. There seems to be a disconnect between the documents and the tests.

Thanks

@simon-friedberger simon-friedberger self-assigned this Jun 24, 2024
@simon-friedberger
Copy link
Contributor

I've removed the part leading and trailing dots are ignored from the wiki. We generally don't allow the empty root label and domains in general are not allowed to have other empty labels. (I am pretty sure, although I cannot find an authoritative reference.)
Presumably, tests.txt encodes the fact that empty labels are not allowed by returning null for the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants