-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave Submissions to the Public Suffix List - Q4 2023 #1872
Conversation
Hi @thypon, am I understanding correctly that you want to have cookie separation for You don't seem to have the required remaining two years of validity on |
Indeed, I think it's correct! The idea here is that a product in Brave, such as search/creators/VPN/..., might have multiple external services (CDN, proxy), which we serve behind a distinct eTLD+1. So if The final objective is to have
Sorted! It should now have >5 years of validity.
|
@thypon And you want to prevent cookie usage on |
You understand that you won't be able to set cookies on |
Nope - while it's not the case - we might use the main eTLD+1 (brave.com) domain to share cookies.
If To be more clear. I would like to have If I understand correctly, with my rule:
The idea is: the If the answer to the following question below is
|
I hope this answers your question: https://github.com/publicsuffix/list/wiki/Format#example If it does not, please let me know what we need to add there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaiu the needs this is good to go.
- The tests pass.
Converting to draft, while I perform the last sanity checks |
Ready! Thanks @simon-friedberger for the review |
@simon-friedberger Here's a suggestion to make it clear that entries at a higher level don't impact lower levels. Add the following just below
and then add these bullet points just below Cookies may be set for foo.com.:
|
Hi @fmarier ! Isn't this exactly what we have?
|
The My suggestion was building on the fact that we can set cookies at the |
Oh, I see. I was thinking of the example as being self contained and independent of the actual PSL. Thanks for clarifying! |
Ah sorry for the confusion. It was definitely a "diff" on the existing example on the wiki :) |
We might have a bug in the |
Given the following concerns we decided to move forward with ConcernsBug in handling wildcards in major librariesI went over all the FOSS implementations in https://publicsuffix.org/learn/ , and I found 3 of them behave funny for Seems to all mislabel eTLD- As an example
Strict eTLD handling in SafariAdditionally, I was not able to test the PSL implementation for Safari which seems to strictly adhere to rfc6265#5.3, unlike any other browser.
|
@thypon You might want to create some issues on those projects. |
I have observed that there can be variance on how this text file catalog of strings is used by implementors. Outside of the algorithm, the PSL is non-prescriptive on how implementors integrate or use the PSL. Nor is there much influence or sway to do things. There are still implementations using stale snapshots from almost a decade ago out in the wild causing fractured UX. Simon's suggestion is the right approach. And good luck. |
Is there any other showstopper to proceed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Public Suffix List (PSL) Pull Request (PR) Template
Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.
Checklist of required steps
Description of Organization
Robust Reason for PSL Inclusion
DNS verification via dig
Run Syntax Checker (make test)
Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section
Submitter affirms the following:
For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.
To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.
PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.
(Link: about propagation/expectations)
Description of Organization
Organization Website: https://brave.com
Submitter: Andrea Brancaleoni
Role: Security Engineer at Brave Software
Brave Software is a technology company that focuses on enhancing the privacy and security of web users. Brave's primary product is the Brave browser: https://brave.com. Besides the browser, Brave also includes an independent Search engine available at https://search.brave.com.
I manage security and operations, ensuring our organizational practices align with our core mission of providing enhanced online privacy and security.
Reason for PSL Inclusion
Number of users this request is being made to serve: 10-100 Million of users.
We believe that the inclusion of our domain(s) in the PSL is of utmost importance for several significant reasons:
img-proxy.search.s.brave.io
, s3 proxied buckets- e.g.userimages.creators.s.brave.io
)All our private section domain names adhere to a long-term registration policy, with current registration terms extending beyond 2 years. We pledge to maintain a registration term of more than one year at all times to ensure our continued presence on the PSL.
We have not made any attempts to work around third-party limits and fully understand the significance of genuine interactions and compliance with all guidelines. We have not previously submitted any issues or PRs related to this particular request.
DNS Verification via dig
Results of Syntax Checker (
make test
)