Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap static blocks by fragment #84

Merged
merged 2 commits into from
Jan 6, 2019

Conversation

ezhlobo
Copy link
Member

@ezhlobo ezhlobo commented Jan 6, 2019

Initial issue: #82 Don't add own keys in static blocks

It makes transpiling this

if true
  div First
  div Second

Into this:

true ? (
  <React.Fragment>
    <div>First</div>
    <div>Second</div>
  </React.Fragment>
) : ...

@codecov-io
Copy link

Codecov Report

Merging #84 into next will decrease coverage by 0.11%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #84      +/-   ##
==========================================
- Coverage   87.04%   86.92%   -0.12%     
==========================================
  Files          21       21              
  Lines         463      459       -4     
  Branches      112      112              
==========================================
- Hits          403      399       -4     
+ Misses         55       54       -1     
- Partials        5        6       +1
Impacted Files Coverage Δ
src/block-key.js 90.62% <ø> (-1.49%) ⬇️
src/visitors/Case.js 77.27% <0%> (ø) ⬆️
src/utils/jsx.js 100% <100%> (ø) ⬆️
src/visitors/Conditional.js 100% <100%> (ø) ⬆️
src/visitors/Each.js 96.29% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048568c...eb5316f. Read the comment docs.

@ezhlobo ezhlobo merged commit fba16ba into pugjs:next Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants