You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removing parameters from services adding dictionaries
Q
A
New Feature
no
RFC
yes
BC Break
yes
Summary
I am thinking to remove all parameters from services file like:
pugx_badge_allin_badges
pugx_badge_badges
In my opinion, is better to have dictionary files to store this information and remove dependencies parameters into SnippetGenerator.php.
In that service, we can call statically those dictionary files instead of injecting parameters array from services file.
What do you think?
I can work into this pull request if it can be of value for this project.
I think it can be a BC because we are changing SnippetGenerator constructor.
The text was updated successfully, but these errors were encountered:
Feature Request
Removing parameters from services adding dictionaries
Summary
I am thinking to remove all parameters from services file like:
In my opinion, is better to have dictionary files to store this information and remove dependencies parameters into
SnippetGenerator.php
.In that service, we can call statically those dictionary files instead of injecting parameters array from services file.
What do you think?
I can work into this pull request if it can be of value for this project.
I think it can be a BC because we are changing SnippetGenerator constructor.
The text was updated successfully, but these errors were encountered: