Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing parameters from services adding dictionaries #769

Closed
AlessandroMinoccheri opened this issue Apr 17, 2022 · 1 comment · Fixed by #771
Closed

Removing parameters from services adding dictionaries #769

AlessandroMinoccheri opened this issue Apr 17, 2022 · 1 comment · Fixed by #771
Assignees

Comments

@AlessandroMinoccheri
Copy link
Member

AlessandroMinoccheri commented Apr 17, 2022

Feature Request

Removing parameters from services adding dictionaries

Q A
New Feature no
RFC yes
BC Break yes

Summary

I am thinking to remove all parameters from services file like:

pugx_badge_allin_badges
pugx_badge_badges

In my opinion, is better to have dictionary files to store this information and remove dependencies parameters into SnippetGenerator.php.
In that service, we can call statically those dictionary files instead of injecting parameters array from services file.

What do you think?

I can work into this pull request if it can be of value for this project.
I think it can be a BC because we are changing SnippetGenerator constructor.

@JellyBellyDev
Copy link
Member

It's a nice idea to me! It's an improvement also to DX side to the maintainability of the software.
Thanks @AlessandroMinoccheri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants