Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move submission notes out of metadata and into the message list #819

Merged
merged 5 commits into from
Jan 6, 2023

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Jan 5, 2023

Screen Shot 2023-01-05 at 1 36 58 PM

This PR just moves the HTML around, but looking at the original issue:

  • Curator receives a numbered notification if a note was included.
  • The numbered notification resolves when a curator reads the note

To do all of that, we'll need to change the model code: should be possible, but it is more complicated.

If this seems valuable as a partial solution, it could be approved... but if it seems better to implement the full solution, then this could be closed.

@mccalluc mccalluc changed the title Mccalluc notes with messages Move submission notes out of metadata and into the message list Jan 5, 2023
@bess
Copy link
Contributor

bess commented Jan 6, 2023

⭐ Looks great!

I made a separate ticket to refactor the code to use consistent language for message instead of comment: #825

@bess bess merged commit ac4031b into main Jan 6, 2023
@bess bess deleted the mccalluc-notes-with-messages branch January 6, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants