Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use "message" instead of "comment" consistently #825

Closed
1 task
bess opened this issue Jan 6, 2023 · 2 comments
Closed
1 task

Refactor: use "message" instead of "comment" consistently #825

bess opened this issue Jan 6, 2023 · 2 comments

Comments

@bess
Copy link
Contributor

bess commented Jan 6, 2023

We recently changed our "comments" into "messages." Instead of just changing the external label, let's also refactor the code to use the same language for these objects consistently. Otherwise it's going to make the code more confusing than it needs to be going forward.

Screenshot 2023-01-06 at 3 05 20 PM

Acceptance Criteria

  • All places where the code references to "comment" have been changes to "message"
@mccalluc
Copy link
Contributor

mccalluc commented Jan 10, 2023

Following #837, there is one remaining piece of work:

class WorkActivity < ApplicationRecord
  CHANGES = "CHANGES"
-  COMMENT = "COMMENT"
+  MESSAGE = "COMMENT" # TODO: Migrate existing records to "MESSAGE"; then close #825.

A migration could be created and run to make sure the code in the database matches the code in the UI and the rest of the codebase.

@kelynch
Copy link
Contributor

kelynch commented Sep 26, 2024

This appears to be completed.

@kelynch kelynch closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants