-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds LUX header and footer #414
Conversation
We'll need to install yarn on dpul-staging1 to deploy this. |
Tried to use yarn for deploy and got an error: NPM works, so sticking with that. Maybe something you can look at @axamei if we want to stick with YARN? Update: Looking into this now, I think it's just a yarn installation problem. |
pulibrary/princeton_ansible#300 is necessary to deploy this. |
Restore new header/footer styles, with fixes to item view and user dropdown
I deployed this to staging and tested it compared to the master branch. I saw some of the same display issues that @tpendragon mentioned above:
I did some basic timings and saved the pages with dependencies using Chrome, and found the Lux versions were a little slower and larger. But turbolinks is a significant factor there, so we should probably talk about the best methodology for testing page sizes and load times. |
@escowles this was branched from master before the header/footer rollback. Those issues may be related to problems with that branch. We are going to redo this from master. @axamei is out today. Can we keep this open until she returns? Re: the benchmarking... Lux is going to add some additional weight while we transition since we are only adding, not yet taking anything away. I agree that we should discuss the best methodology for testing. I think Lighthouse audits are a pretty good way to do this. |
@sdellis It's totally fine to leave this open a while (as long as you think it's worth having around in fact). Basing off the updated master branch makes sense, and hopefully resolves some of the styling issues. I'll take a look at Lighthouse. I don't think modest page size or load time increases would be a problem (in fact, that's what I expect because we're adding Lux and not removing anything else yet). I was mostly just curious about what the impact was. |
Going to start a new branch from the current master. This is too messy. |
Feel free to close in favor of #418 |
Closed in favor of #418 |
No description provided.