Adding browserconfig.xml and Apple touch icons as static assets for catalog requests; Implementing a route for WP login attempts #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escowles
reviewed
Jan 4, 2019
config/routes.rb
Outdated
| @@ -27,6 +27,7 @@ | |||
| match '/404', to: 'pages#not_found', via: :all | |||
| match '/500', to: 'pages#internal_server_error', via: :all | |||
| get '/viewers', to: 'pages#viewers', as: 'viewers_page' | |||
| get '/browserconfig.xml', to: redirect('/browserconfig.xml') | |||
There was a problem hiding this comment.
Is this needed? Wouldn't the browserconfig.xml file being in public be enough to serve it at that URL?
jrgriffiniii
changed the title
|
This should also be rescoped to encompass serving static assets for Apple devices: https://app.honeybadger.io/projects/51733/faults/42762574/bc9f68b2-0f16-11e9-85e7-637f17c49e70#notice-summary |
Apple touch icons; Adding routing support for Wordpress login attempts
jrgriffiniii
force-pushed
the
issues-470-jrgriffiniii-browserconfig
branch
from
b05a14a
to
398260f
Compare
jrgriffiniii
changed the title
|
I can remove the WP route and look to resolve this at the level of KEMP, but my conclusion from #470 (comment) is that this was already attempted and proven ineffective: https://app.honeybadger.io/projects/51733/faults/42762574/750a540c-0f80-11e9-8827-18bf85578728#notice-summary |
|
I'm 👍 on the |
escowles
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #470