Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external users #751

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Allow external users #751

merged 1 commit into from
Mar 2, 2020

Conversation

hackartisan
Copy link
Member

@hackartisan hackartisan commented Feb 28, 2020

Their uid and username are both their email address. princeton.edu is no
longer appended to make the email address if the uid is already an email address.

This should be deployed to staging and tested.

progresses #750

Their uid and username are both their email address. princeton.edu is no
longer appended to make the email address if the uid is already an email address.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0498628 on 750-external-users into 977c59b on master.

@tpendragon tpendragon temporarily deployed to staging March 2, 2020 16:10 Inactive
@hackartisan
Copy link
Member Author

I tested this fix on staging and it works for a general case. I couldn't figure out how to "invite" a user so I didn't test that functionality.

@kelea99
Copy link
Contributor

kelea99 commented Mar 2, 2020

@HackMasterA I invite a user simply by adding them to a collection and letting them know about their collection. I wonder if there is a better way?

@hackartisan
Copy link
Member Author

@kelea99 that's the process I've tested, and I think it works fine. The code has a concept of a "pending invitation" but I'm not sure how that manifests in UI. @tpendragon any idea?

But I think the test should suffice to ensure it's working okay and also that if we're not using this feature we don't need to worry about it too much.

@tpendragon
Copy link
Contributor

No, I'm not sure. I think that's a Spotlight system that we just kind of ignored?

@tpendragon tpendragon merged commit 4956ede into master Mar 2, 2020
@tpendragon tpendragon deleted the 750-external-users branch March 2, 2020 17:35
@kelea99
Copy link
Contributor

kelea99 commented Mar 2, 2020

sounds good to me, @HackMasterA. Im so glad its working in staging! When you are ready, just let me know and Ill contact the collection owner to give it a try. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants