-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing dependency for a specific gcc version #25
Removing dependency for a specific gcc version #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes look good to me, thanks for your contribution! Those are the compilers we use to compile GCC in our internal machines, this should not have been pushed to the open-source version of Ara.
I need a few stylistic changes before I can accept this PR. Could you please update the CHANGELOG
file with your change? Also, we write our commit messages in the imperative tense, with a small tag indicating what does the commit change. For this commit, I imagine the [Makefile]
tag would be appropriate.
Ok got it, I will add a commit tag. |
Hello Hossein, thanks a lot for your contribution.
Keeping the imperative form for the first verb, and avoiding merges from external branches. One useful tool to achieve this history from the current state can be Let us know if you need more information, and thanks again for the patience! ;-) |
227b162
to
af3dd33
Compare
af3dd33
to
2ca7486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution @hossein1387!
Description of PR that completes issue here...
Changelog
Fixed
Added
gcc
andg++
commands so that the correct version is picked up by the build systemChanged
gcc
andg++
commands so that the correct version is picked up by the build systemChecklist
Please check our contributing guidelines before opening a Pull Request.