Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock gate and isolate Islands on reset #108

Merged
merged 14 commits into from
Sep 23, 2023
Merged

Clock gate and isolate Islands on reset #108

merged 14 commits into from
Sep 23, 2023

Conversation

bluewww
Copy link
Contributor

@bluewww bluewww commented Jul 26, 2023 •
edited by alex96295

[EDIT] @alex96295:

  • Update default reset value for isolation and clock gating of carfield's domains (currently, the peripheral domain is left out from isolation/clock gating. It might cause Linux boot complications so we should consider leaving it on by default.)
  • Create a system_init() function with constructor attribute to initialize isolation and clock gating of domains in non-secure bootmode -> in a future PR

Fixes #71
Fixes #126
Fixes #46

@alex96295 alex96295 added the design Wire missing connection, undesired latches, parameter tuning (functionality still correct) label Aug 1, 2023
@alex96295 alex96295 changed the title Clock gate and isolate Islands on reset Draft: Clock gate and isolate Islands on reset Aug 8, 2023
@bluewww bluewww force-pushed the balasr/clk-en branch 2 times, most recently from 315055b to a66c6e2 Compare August 11, 2023 17:08
@alex96295 alex96295 added enhancement New feature or request and removed design Wire missing connection, undesired latches, parameter tuning (functionality still correct) labels Aug 25, 2023
@alex96295
Copy link
Collaborator

Rebased onto main

@alex96295 alex96295 force-pushed the balasr/clk-en branch 4 times, most recently from 4a2b77f to 6f05870 Compare September 1, 2023 12:32
@alex96295 alex96295 mentioned this pull request Aug 14, 2023
Closed
@alex96295 alex96295 force-pushed the balasr/clk-en branch 2 times, most recently from 8af7895 to 216c58c Compare September 4, 2023 06:40
@alex96295
Copy link
Collaborator

Rebased onto main

@bluewww bluewww force-pushed the balasr/clk-en branch 3 times, most recently from f53cbb4 to 0f52f14 Compare September 22, 2023 22:55
bluewww and others added 11 commits September 23, 2023 03:07
@bluewww
treewide: Add secure boot mode
fff20d8 
* Makes sure that security island comes up after reset together with
host domain. This allows the security island to control the boot flow
assuming the host domain is put in the correct boot mode too.
* Prevents safety island isolate and clock enables from shutting off
safety island
@bluewww
hw/regs: Clock gate and isolate islands on PoR
775fc83
@bluewww
hw,sw: Re-generate soc ctrl regs
ce636c9
@alex96295 @bluewww
sw/include: Add helpers to de-isolate and clock islands at startup
0636298 
* Currently, the init function has to be called manually
@alex96295 @bluewww
sw/tests: Call de-isolation and clock init function manually
291ea74
@alex96295 @bluewww
tb: Add tasks to enable clock and de-isolate Safety Island after PoR
00cb0e9 
* Required to run standalone tests on the safety island with the current
clock enable and isolation strategy in non-secure boot mode
@bluewww
Update .gitignore
871981c
@bluewww
tb: Normalize $display statements
bf70d89 
We will use the [TB] prefix to make messages easily greppable.
@bluewww
tb: Define $timeformat for displaying time
a8630e7
@bluewww
tb: Enable clock and de-isolate for safety island stand alone tests
5a96ee3
@bluewww
sw: Simplify domain managment
81000fc
@bluewww
Makefile: Fix missing PHONY
312f68b
@bluewww
sw/tests: Update golden timer value expected
e7d6292 
This changes due to additional initialization code for programming the
clock domains
@bluewww
sw/tests: Do not try to software reset security domain
3b19a35 
The problem is that this doesn't by work in secure boot mode by
definition. We don't really have a programmatic way to determine whether
we are secure booting atm so we need to disable this part of the test.
@alex96295 alex96295 changed the title Draft: Clock gate and isolate Islands on reset Clock gate and isolate Islands on reset Sep 23, 2023
@alex96295 alex96295 marked this pull request as ready for review September 23, 2023 07:59
@alex96295 alex96295 self-requested a review as a code owner September 23, 2023 07:59
alex96295
alex96295 approved these changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@alex96295 alex96295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluewww bluewww merged commit a10f0ea into main Sep 23, 2023
7 checks passed
@bluewww bluewww deleted the balasr/clk-en branch September 23, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex96295 alex96295 alex96295 approved these changes

Assignees

@bluewww bluewww

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@bluewww @alex96295