Fix for SBA 'be' when reading (fixes #22). #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6d8ddf47c3152326bb9f804ee91af9ac3e1690f2 Signed-off-by: John Eric Martin <John.Martin@emmicro-us.com>
|
I want to make this a parameter, so that we stay compatible with the current way we do it. |
|
Do you have a naming preference for this parameter? Perhaps ReadByteEnable=1 to default to the new behavior. Bring it out of dm_top with the other parameters? |
Change-Id: If416f3489d46b1e22f680f5283ad78462bcc72e4
…store the old behavior if desired. Change-Id: Ic97ce3f77664360822ecb6834baf180e98b14fcf Signed-off-by: John Eric Martin <John.Martin@emmicro-us.com>
|
@bluewww I added a parameter at your request. Please review when you get a chance. |
|
Thanks for the PR Ill look into it |
|
Could you please make an entry in the CHANGELOG.md, then it is good to go. |
Change-Id: Id38e03fbfec0570dd7edf47686690dc313b29085 Signed-off-by: John Eric Martin <John.Martin@emmicro-us.com>
|
@bluewww Added to the changelog. Thanks for looking at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
@bluewww It looks like you have a branch that addressed this with a copy & paste of the combinatorial logic but it never got merged in.