This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
snitch_cluster: Re-add wake-up register
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for this! All my code with omp runtime works with this implementation of the The address for the barrier register changed as well correct? Then there should be this change in the
snitch/sw/snRuntime/src/start_cluster.c Line 76 in e878d4d |
|
Thanks for being so attentive, yes that should be shifted as well. I somehow thought that it is derived from the generated C header file, apparently, I was wrong. |
|
Nice, the rest looks good to me 👍 |
paulsc96
pushed a commit
to pulp-platform/snitch_cluster
that referenced
this pull request
Jul 11, 2023
* snitch_cluster: Re-add `wake-up` register * Shift barrier reg in SW
paulsc96
pushed a commit
to pulp-platform/snitch_cluster
that referenced
this pull request
Jul 11, 2023
…(#111s)) * snitch_cluster: Re-add `wake-up` register * Shift barrier reg in SW
paulsc96
pushed a commit
to pulp-platform/snitch_cluster
that referenced
this pull request
Jul 11, 2023
* snitch_cluster: Re-add `wake-up` register * Shift barrier reg in SW
colluca
pushed a commit
to pulp-platform/snitch_cluster
that referenced
this pull request
Jul 11, 2023
* snitch_cluster: Re-add `wake-up` register * Shift barrier reg in SW
paulsc96
pushed a commit
to pulp-platform/snitch_cluster
that referenced
this pull request
Jul 11, 2023
* snitch_cluster: Re-add `wake-up` register * Shift barrier reg in SW
paulsc96
pushed a commit
to pulp-platform/snitch_cluster
that referenced
this pull request
Jul 11, 2023
* snitch_cluster: Re-add `wake-up` register * Shift barrier reg in SW
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adds the wake-up register. Following the Mempool implementation. As I don't have any meaningful set-up to test the implementation I'd appreciate your feedback @Noah95