-
Notifications
You must be signed in to change notification settings - Fork 51
occamy: Generate c defines for soc peripheral registers #277
Conversation
389e2f3
to
0f3928c
Compare
0f3928c
to
eb2fc1f
Compare
eb2fc1f
to
fc17e19
Compare
473f43d
to
bfe6d0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, two things we should think through before further extending this:
- Should this be built as part of the SW/Occamy runtime or the Occamy RTL?
- Should this be put in an Occamy-specific SW subtree?
We currently don't have a Occamy specific runtime so we cannot include it there.
I think that is the best option for the future. There will be some occamy-specific tests following, which need to be put somewhere. Then we could just add some cmake flag if Occamy sources should be built as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thanks for finishing this @SamuelRiedel
There will be some occamy-specific tests following
The runtime generates libraries for different HW, so we could add a new target there for Occamy and make this header a dependency
// Solderpad Hardware License, Version 0.51, see LICENSE for details. | ||
// SPDX-License-Identifier: SHL-0.51 | ||
// Licensed under Solderpad Hardware License, Version 0.51, see LICENSE for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed twice? ( Solderpad Hardware License... on line 2 and Licensed under Solderpad Hardware... in line 4)
Does anyone have another input here (check my comment) or can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…m/snitch#277) * occamy: Generate c defines for soc peripheral registers * lint and license * regenerate headers with updated read-only cache * Install `clang-format` in Ci to generate Occamy files Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
…rm/snitch#277](#277s)) * occamy: Generate c defines for soc peripheral registers * lint and license * regenerate headers with updated read-only cache * Install `clang-format` in Ci to generate Occamy files Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
…m/snitch#277) * occamy: Generate c defines for soc peripheral registers * lint and license * regenerate headers with updated read-only cache * Install `clang-format` in Ci to generate Occamy files Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
…m/snitch#277) * occamy: Generate c defines for soc peripheral registers * lint and license * regenerate headers with updated read-only cache * Install `clang-format` in Ci to generate Occamy files Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
…m/snitch#277) * occamy: Generate c defines for soc peripheral registers * lint and license * regenerate headers with updated read-only cache * Install `clang-format` in Ci to generate Occamy files Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
…m/snitch#277) * occamy: Generate c defines for soc peripheral registers * lint and license * regenerate headers with updated read-only cache * Install `clang-format` in Ci to generate Occamy files Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
…m/snitch#277) * occamy: Generate c defines for soc peripheral registers * lint and license * regenerate headers with updated read-only cache * Install `clang-format` in Ci to generate Occamy files Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
No description provided.