Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

occamy: Generate c defines for soc peripheral registers #277

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

huettern
Copy link
Collaborator

No description provided.

@SamuelRiedel SamuelRiedel force-pushed the feature/occamy-soc-reg-cdef branch 2 times, most recently from 473f43d to bfe6d0a Compare October 22, 2021 12:38
@SamuelRiedel SamuelRiedel marked this pull request as ready for review October 22, 2021 13:28
@SamuelRiedel
Copy link
Member

@Noah95, @fischeti I think we can merge this or start discussing it. The configuration is now up to date and the Ci works. We might just discuss where to put the generated header since it's Occamy specific.

Copy link
Collaborator

@paulsc96 paulsc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, two things we should think through before further extending this:

  • Should this be built as part of the SW/Occamy runtime or the Occamy RTL?
  • Should this be put in an Occamy-specific SW subtree?

@fischeti
Copy link
Contributor

* Should this be built as part of the SW/Occamy runtime or the Occamy RTL?

We currently don't have a Occamy specific runtime so we cannot include it there.

* Should this be put in an Occamy-specific SW subtree?

I think that is the best option for the future. There will be some occamy-specific tests following, which need to be put somewhere. Then we could just add some cmake flag if Occamy sources should be built as well

Copy link
Collaborator Author

@huettern huettern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for finishing this @SamuelRiedel

There will be some occamy-specific tests following

The runtime generates libraries for different HW, so we could add a new target there for Occamy and make this header a dependency

Comment on lines 2 to +4
// Solderpad Hardware License, Version 0.51, see LICENSE for details.
// SPDX-License-Identifier: SHL-0.51
// Licensed under Solderpad Hardware License, Version 0.51, see LICENSE for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed twice? ( Solderpad Hardware License... on line 2 and Licensed under Solderpad Hardware... in line 4)

@GiannaP
Copy link
Contributor

GiannaP commented Nov 2, 2021

Does anyone have another input here (check my comment) or can we merge this?

Copy link
Contributor

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulsc96 paulsc96 merged commit 06e92e9 into master Nov 2, 2021
@paulsc96 paulsc96 deleted the feature/occamy-soc-reg-cdef branch November 2, 2021 16:00
paulsc96 pushed a commit to pulp-platform/snitch_cluster that referenced this pull request Jul 11, 2023
…m/snitch#277)

* occamy: Generate c defines for soc peripheral registers

* lint and license

* regenerate headers with updated read-only cache

* Install `clang-format` in Ci to generate Occamy files

Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
paulsc96 pushed a commit to pulp-platform/snitch_cluster that referenced this pull request Jul 11, 2023
…rm/snitch#277](#277s))

* occamy: Generate c defines for soc peripheral registers

* lint and license

* regenerate headers with updated read-only cache

* Install `clang-format` in Ci to generate Occamy files

Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
paulsc96 pushed a commit to pulp-platform/snitch_cluster that referenced this pull request Jul 11, 2023
…m/snitch#277)

* occamy: Generate c defines for soc peripheral registers

* lint and license

* regenerate headers with updated read-only cache

* Install `clang-format` in Ci to generate Occamy files

Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
colluca pushed a commit to pulp-platform/snitch_cluster that referenced this pull request Jul 11, 2023
…m/snitch#277)

* occamy: Generate c defines for soc peripheral registers

* lint and license

* regenerate headers with updated read-only cache

* Install `clang-format` in Ci to generate Occamy files

Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
paulsc96 pushed a commit to pulp-platform/snitch_cluster that referenced this pull request Jul 11, 2023
…m/snitch#277)

* occamy: Generate c defines for soc peripheral registers

* lint and license

* regenerate headers with updated read-only cache

* Install `clang-format` in Ci to generate Occamy files

Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
paulsc96 pushed a commit to pulp-platform/snitch_cluster that referenced this pull request Jul 11, 2023
…m/snitch#277)

* occamy: Generate c defines for soc peripheral registers

* lint and license

* regenerate headers with updated read-only cache

* Install `clang-format` in Ci to generate Occamy files

Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
colluca pushed a commit to pulp-platform/occamy that referenced this pull request Aug 19, 2023
…m/snitch#277)

* occamy: Generate c defines for soc peripheral registers

* lint and license

* regenerate headers with updated read-only cache

* Install `clang-format` in Ci to generate Occamy files

Co-authored-by: Samuel Riedel <sriedel@iis.ee.ethz.ch>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants