Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for client cert auth #122

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Add support for client cert auth #122

merged 1 commit into from
Feb 6, 2021

Conversation

daviddavis
Copy link
Contributor

[noissue]

@daviddavis daviddavis force-pushed the client-cert-auth branch 2 times, most recently from 4916929 to 43e0dca Compare February 5, 2021 20:57
@daviddavis daviddavis marked this pull request as ready for review February 5, 2021 21:06
@ianballou
Copy link

Working for me with Katello!

@daviddavis daviddavis force-pushed the client-cert-auth branch 2 times, most recently from c1c0993 to 0d984ab Compare February 5, 2021 21:16
ianballou
ianballou reviewed Feb 5, 2021
View reviewed changes
README.md
@@ -65,6 +65,19 @@ login admin
password password
```

### Katello
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Tested with a Katello development box.

@daviddavis daviddavis force-pushed the client-cert-auth branch 2 times, most recently from 6f7c3cf to edd3121 Compare February 6, 2021 15:16
mdellweg
mdellweg approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@daviddavis daviddavis merged commit a12180c into pulp:develop Feb 6, 2021
@mdellweg mdellweg added this to the 0.4.0 milestone Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianballou ianballou ianballou left review comments

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daviddavis @ianballou @mdellweg